[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Run docker probe only if docker or podman are available

From: Stefan Weil
Subject: Re: [PATCH] Run docker probe only if docker or podman are available
Date: Wed, 2 Nov 2022 21:28:37 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1

Am 30.10.22 um 09:35 schrieb Stefan Weil:

The docker probe uses "sudo -n" which can cause an e-mail with a security 
each time when configure is run. Therefore run docker probe only if either 
or podman are available.

That avoids the problematic "sudo -n" on build environments which have neither
docker nor podman installed.

Fixes: c4575b59155e2e00 ("configure: store container engine in config-host.mak")
Signed-off-by: Stefan Weil <sw@weilnetz.de>
  configure | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 81561be7c1..3af99282b7 100755
--- a/configure
+++ b/configure
@@ -1779,7 +1779,7 @@ fi
  # functions to probe cross compilers
-if test $use_containers = "yes"; then
+if test $use_containers = "yes" && (has "docker" || has "podman"); then
      case $($python "$source_path"/tests/docker/docker.py probe) in
          *docker) container=docker ;;
          podman) container=podman ;;

Can this patch be applied by qemu-trivial? For me those security e-mails are a bug and should be at least avoided as far as possible in the new QEMU release.

Thanks, Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]