[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled in
From: |
Anthony PERARD |
Subject: |
Re: [PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled in |
Date: |
Wed, 27 Apr 2022 14:38:45 +0100 |
On Wed, Apr 27, 2022 at 02:33:16PM +0200, Thomas Huth wrote:
> The 'xenfb' parameter for the '-vga' command line option is currently
> always enabled unconditionally (since the xenfb is not a proper QOM
> device that could be tested via its class name). That means it also
> shows up if Xen is not enabled at all, e.g. like this:
>
> $ ./qemu-system-sparc -vga help
> none no graphic card
> xenfb Xen paravirtualized framebuffer
> tcx TCX framebuffer (default)
> cg3 CG3 framebuffer
>
> Let's avoid this situation by fencing the parameter with the
> CONFIG_XEN_BACKEND switch.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD