Re: [PATCH v2 1/2] ci: Add github workflow for getting cirrus working properly

[Yonggang Luo]

On Wed, Mar 23, 2022 at 3:44 PM Thomas Huth <thuth@redhat.com> wrote:
>
> On 22/03/2022 20.14, Yonggang Luo wrote:
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
>
> Missing patch description ... why is this needed? I can't see anything
> related to Cirrus-CI in here?

Here is the place report failure

https://github.com/qemu/qemu/runs/5652470682

Here is the place showing the valid ci result:

https://github.com/lygstate/qemu

>
> > ---
> >   .github/workflows/main.yml | 29 +++++++++++++++++++++++++++++
> >   MAINTAINERS                |  4 +++-
> >   2 files changed, 32 insertions(+), 1 deletion(-)
> >   create mode 100644 .github/workflows/main.yml
> >
> > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> > new file mode 100644
> > index 0000000000..85a392b962
> > --- /dev/null
> > +++ b/.github/workflows/main.yml
> > @@ -0,0 +1,29 @@
> > +# This is a basic workflow to help you get started with Actions
> > +
> > +name: CI
> > +
> > +# Controls when the action will run. Triggers the workflow on push or pull request
> > +# events but only for the master branch
> > +on:
> > +  push:
> > +    branches: [ master ]
> > +  pull_request:
> > +    branches: [ master ]
> > +
> > +# A workflow run is made up of one or more jobs that can run sequentially or in parallel
> > +jobs:
> > +  check-patch:
> > +    name: Check Patch
> > +    runs-on: ubuntu-latest
> > +    steps:
> > +      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
> > +      - uses: actions/checkout@v2
> > +        with:
> > +          fetch-depth: 0
> > +      - name: Install dependent packages
> > +        run: sudo apt install perl
> > +      - name: Checkpatch
> > +        run: |
> > +          git fetch https://git.qemu.org/git/qemu.git master
> > +          git tag base_tag_to_rebase FETCH_HEAD --force
> > +          ./scripts/checkpatch.pl --mailback base_tag_to_rebase..
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index cc364afef7..6d1dcc36b0 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3612,10 +3612,12 @@ Build and test automation, general continuous integration
> >   M: Alex Bennée <alex.bennee@linaro.org>
> >   M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >   M: Thomas Huth <thuth@redhat.com>
> > +M: Yonggang Luo <luoyonggang@gmail>
> >   R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> >   R: Beraldo Leal <bleal@redhat.com>
> >   S: Maintained
> > -F: .github/lockdown.yml
> > +F: .github/workflows/lockdown.yml
> > +F: .github/workflows/main.yml
> >   F: .gitlab-ci.yml
> >   F: .gitlab-ci.d/
> >   F: .travis.yml
>
> You also don't mention that change anywhere. And IIRC you've also only been
> involved in the Windows-related CI tasks so far? So it might make more sense
> to update the "Windows Hosted Continuous Integration" section instead?
>
>   Thomas
>


--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo