Re: [PATCH] erst: drop cast to long long

[Thomas Huth]

On 06/02/2022 10.35, Michael S. Tsirkin wrote:
> The way to print uint64_t is with PRIx64, not with
> a cast to long long.
>
> Cc: Eric DeVolder <eric.devolder@oracle.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   tests/qtest/erst-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/erst-test.c b/tests/qtest/erst-test.c
> index c6a0ae4013..f94cd8dd8e 100644
> --- a/tests/qtest/erst-test.c
> +++ b/tests/qtest/erst-test.c
> @@ -75,7 +75,7 @@ static inline uint64_t in_reg64(ERSTState *s, unsigned reg)
>       uint64_t res;
>   
>       res = qpci_io_readq(s->dev, s->reg_bar, reg);
> -    g_test_message("*%s -> %016llx", name, (unsigned long long)res);
> +    g_test_message("*%s -> %016" PRIx64, name, res);
>   
>       return res;
>   }

Reviewed-by: Thomas Huth <thuth@redhat.com>