[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qapi/block: Cosmetic change in BlockExportType schema

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] qapi/block: Cosmetic change in BlockExportType schema
Date: Tue, 1 Feb 2022 00:19:43 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 31/1/22 22:37, Eric Blake wrote:
On Sun, Jan 30, 2022 at 07:50:41PM +0100, Philippe Mathieu-Daudé wrote:
On 28/1/22 21:54, Eric Blake wrote:
On Wed, Jan 19, 2022 at 01:14:39PM +0100, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daude <f4bug@amsat.org>

'git am' used this line to insert the authorship...

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

...then left this line in the commit body, which I manually deleted,
without spotting the difference between the two.

The doubled From: looks odd here.  I'll double-check that git doesn't
mess up the actual commit once I apply the patch.

I played with the git --from option to not appear in the list as
'"Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>':
by using a different sendemail.from (removing the acute in my
lastname) to force a correct author.from.
git-am should have picked the 2nd form, but I see the 1st in commit
3a8fa0edd1. Just curious, did you had to modify it manually?

Alas, since I managed to overlook the change in the acute (I suppose
I'm cursed with having a boring name, so unlike many list participants
who are overjoyed by the power of UTF-8 to make self-expression more
accurate, I have not had as much experience with thinking about it),
my manual edits explain why the merged commit ended up with a less
desirable spelling.  I apologize for the mishap.  Do we need/want a
.mailmap entry to aid git at listing your preferred spelling?

A missing acute is not a big deal, compared to other alphabets where
people try to approximate their name pronunciation to Latin symbols,
and is still better than UTF-8 mojibake :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]