Re: [PATCH] qapi/block: Cosmetic change in BlockExportType schema

[Philippe Mathieu-Daudé]

On 28/1/22 21:54, Eric Blake wrote:
> On Wed, Jan 19, 2022 at 01:14:39PM +0100, Philippe Mathieu-Daudé wrote:
> > From: Philippe Mathieu-Daude <f4bug@amsat.org>
> >
> > From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> The doubled From: looks odd here.  I'll double-check that git doesn't
> mess up the actual commit once I apply the patch.

I played with the git --from option to not appear in the list as
'"Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>':
https://lore.kernel.org/qemu-devel/efc5f304-f3d2-ff7b-99a6-673595ff0259@amsat.org/
by using a different sendemail.from (removing the acute in my
lastname) to force a correct author.from.
git-am should have picked the 2nd form, but I see the 1st in commit
3a8fa0edd1. Just curious, did you had to modify it manually?

Anyway, thanks for merging this :)

> > Fix long line introduced in commit bb01ea73110 ("qapi/block:
> > Restrict vhost-user-blk to CONFIG_VHOST_USER_BLK_SERVER").
> >
> > Suggested-by: Markus Armbruster <armbru@redhat.com>
> > Acked-by: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >   qapi/block-export.json | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)