[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/riscv: Fix position of 'experimental' comment

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] target/riscv: Fix position of 'experimental' comment
Date: Thu, 6 Jan 2022 20:51:38 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1

Cc'ing qemu-trivial@

On 6/1/22 14:40, Philipp Tomsich wrote:
When commit 0643c12e4b dropped the 'x-' prefix for Zb[abcs] and set
them to be enabled by default, the comment about experimental
extensions was kept in place above them.  This moves it down a few
lines to only cover experimental extensions.

References: 0643c12e4b ("target/riscv: Enable bitmanip Zb[abcs] instructions")

Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  target/riscv/cpu.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 6ef3314bce..e322e729d2 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -640,11 +640,12 @@ static Property riscv_cpu_properties[] = {
      DEFINE_PROP_UINT16("vlen", RISCVCPU, cfg.vlen, 128),
      DEFINE_PROP_UINT16("elen", RISCVCPU, cfg.elen, 64),
- /* These are experimental so mark with 'x-' */
      DEFINE_PROP_BOOL("zba", RISCVCPU, cfg.ext_zba, true),
      DEFINE_PROP_BOOL("zbb", RISCVCPU, cfg.ext_zbb, true),
      DEFINE_PROP_BOOL("zbc", RISCVCPU, cfg.ext_zbc, true),
      DEFINE_PROP_BOOL("zbs", RISCVCPU, cfg.ext_zbs, true),
+    /* These are experimental so mark with 'x-' */
      DEFINE_PROP_BOOL("x-h", RISCVCPU, cfg.ext_h, false),
      DEFINE_PROP_BOOL("x-j", RISCVCPU, cfg.ext_j, false),
      /* ePMP 0.9.3 */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]