[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/6] tests/qtest/virtio-net: fix hotplug test case
From: |
Laurent Vivier |
Subject: |
[PULL 5/6] tests/qtest/virtio-net: fix hotplug test case |
Date: |
Tue, 9 Nov 2021 10:12:37 +0100 |
From: Laurent Vivier <lvivier@redhat.com>
virtio-net-test has an hotplug testcase that is never executed.
This is because the testcase is attached to virtio-pci interface
rather than to virtio-net-pci.
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep
hotplug
/x86_64/.../pci-ohci-tests/ohci_pci-test-hotplug
/x86_64/.../e1000e/e1000e-tests/hotplug
/x86_64/.../virtio-blk-pci/virtio-blk-pci-tests/hotplug
/x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
/x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
/x86_64/.../virtio-scsi/virtio-scsi-tests/hotplug
/x86_64/.../virtio-serial/virtio-serial-tests/hotplug
With this fix:
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep
hotplug
...
/x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
/x86_64/.../virtio-net-pci/virtio-net-pci-tests/hotplug
/x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
...
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -p
/x86_64/.../virtio-net-pci-tests/hotplug
/x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-net-pci/virtio-net-pci-tests/hotplug:
OK
Fixes: 6ae333f91b99 ("qos-test: virtio-net test node")
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20211028173014.139692-1-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
tests/qtest/virtio-net-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/virtio-net-test.c b/tests/qtest/virtio-net-test.c
index a08e2ffe123f..8bf74e516cce 100644
--- a/tests/qtest/virtio-net-test.c
+++ b/tests/qtest/virtio-net-test.c
@@ -319,7 +319,7 @@ static void register_virtio_net_test(void)
.before = virtio_net_test_setup,
};
- qos_add_test("hotplug", "virtio-pci", hotplug, &opts);
+ qos_add_test("hotplug", "virtio-net-pci", hotplug, &opts);
#ifndef _WIN32
qos_add_test("basic", "virtio-net", send_recv_test, &opts);
qos_add_test("rx_stop_cont", "virtio-net", stop_cont_test, &opts);
--
2.31.1
- [PULL 2/6] hw/core/machine: Add the missing delimiter in cpu_slot_to_string(), (continued)
- [PULL 0/6] Trivial branch for 6.2 patches, Laurent Vivier, 2021/11/09
- [PULL 1/6] hmp: Add shortcut to stop command to match cont, Laurent Vivier, 2021/11/09
- [PULL 2/6] hw/m68k: Fix typo in SPDX tag, Laurent Vivier, 2021/11/09
- [PULL 4/6] meson: Fix 'interpretor' typo, Laurent Vivier, 2021/11/09
- [PULL 5/6] tests/qtest/virtio-net: fix hotplug test case,
Laurent Vivier <=
- [PULL 3/6] .mailmap: Fix more contributor entries, Laurent Vivier, 2021/11/09
- [PULL 6/6] docs/about/deprecated: Remove empty 'related binaries' section, Laurent Vivier, 2021/11/09
- Re: [PULL 0/6] Trivial branch for 6.2 patches, Richard Henderson, 2021/11/09