[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 20/24] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_ar

From: Warner Losh
Subject: Re: [PATCH 20/24] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args
Date: Fri, 29 Oct 2021 20:47:07 -0600

On Thu, Oct 28, 2021 at 4:41 PM Warner Losh <imp@bsdimp.com> wrote:

On Thu, Oct 28, 2021 at 11:25 AM Richard Henderson <richard.henderson@linaro.org> wrote:
On 10/19/21 9:44 AM, Warner Losh wrote:
> +    regs->regs[TARGET_REG_PC] = ka->_sa_handler;

Surely there should be some handling of thumb addresses here.

Yes. I've added code to do this, but haven't run it through (a) our normal
test suite and (b) don't think I have any code that's normal mode with a
thumb mode signal handler to test it with... It will be in the next iteration
I send out.

FYI: I've fixed it in  the patch stream. I wrote 4 test programs: one in a32 mode,
one in T32 mode, one starts in A32 and gets a signal in T32 mode and a final
one that starts in T32 and signals in A32 mode. They all work now. Before
all but the A32 one failed.

And the test suite runs about the same as before. I'll have to add these 4 programs
to the test suite :)... So good call. Thanks on this and the other difficult ones you


reply via email to

[Prev in Thread] Current Thread [Next in Thread]