[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Trim some trailing space from human-readable output
From: |
Markus Armbruster |
Subject: |
Re: [PATCH] Trim some trailing space from human-readable output |
Date: |
Mon, 25 Oct 2021 11:12:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Nominating for qemu-trivial.
Tweaking the subject to
monitor: Trim some trailing space from human-readable output
as Philippe suggested would be nice.
Markus Armbruster <armbru@redhat.com> writes:
> I noticed -cpu help printing enough trailing spaces to make the output
> at least 84 characters wide. Looks ugly unless the terminal is wider.
> Ugly or not, trailing spaces are stupid.
>
> The culprit is this line in x86_cpu_list_entry():
>
> qemu_printf("x86 %-20s %-58s\n", name, desc);
>
> This prints a string with minimum field left-justified right before a
> newline. Change it to
>
> qemu_printf("x86 %-20s %s\n", name, desc);
>
> which avoids the trailing spaces and is simpler to boot.
>
> A search for the pattern with "git-grep -E '%-[0-9]+s\\n'" found a few
> more instances. Change them similarly.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
- Re: [PATCH] Trim some trailing space from human-readable output,
Markus Armbruster <=