[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

From: Warner Losh
Subject: Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host
Date: Tue, 5 Oct 2021 14:46:12 -0600

On Tue, Oct 5, 2021 at 2:41 PM Laurent Vivier <laurent@vivier.eu> wrote:
Le 05/10/2021 à 21:26, Paolo Bonzini a écrit :
> On 27/09/21 11:52, Daniel P. Berrangé wrote:
>>    bsd_user_ss.add(files('gdbstub.c'))
>>    specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
>> So without this change, we're already correctly dropping bsd_user_ss
>> in its entirity, when not on BSD.
>> With this change, we're dropping some, but not all, of bsd_user_ss
>> files - gdbstub.c remains.
>> So this change on its own doesn't make a whole lot of sense.
> Agreed; that said, the gdbstub.c files added by
>   bsd_user_ss.add(files('gdbstub.c'))
>   linux_user_ss.add(files('gdbstub.c', 'thunk.c'))
> are unnecessary because there is already
>   specific_ss.add(files('cpu.c', 'disas.c', 'gdbstub.c'), capstone)
> So, with those two instances of gdbstub.c removed, both patches are
>   Acked-by: Paolo Bonzini <pbonzini@redhat.com>

I can take them if a v2 is sent updated accordingly...

I'd planned on rolling them into the bsd-user patch set that I'd been working on
that is almost ready to go in (this is I think the only remaining issue with the patch
train, though I need to double check threads). I'd planned on doing that tomorrow,
but would be happy to coordinate with you since one of them does touch linux-user.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]