[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH qemu] issue 371: convert tabs to spaces for the block subsyst

From: Thomas Huth
Subject: Re: [PATCH qemu] issue 371: convert tabs to spaces for the block subsystem.
Date: Wed, 29 Sep 2021 08:38:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 29/09/2021 07.30, ~farzon wrote:
From: Farzon Lotfi <farzonl@icloud.com>


Thanks for your contribution! However, there are some more rules that need to be followed to get a patch accepted in the QEMU project:

Please provide a proper patch description for your changes (something like: "QEMU coding style mandates spaces for indentation, so the TABs should get replaced in these files" or something similar should do it here).

Then it would be nice to have a "Resolves:" line in here, too:

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371

That way, the issue gets closed automatically once the patch has been accepted. Then please also drop the "issue 371:" from the subject line.

See also:

And finally, the most important one: You need to supply a "Signed-off-by:" line at the end of the patch description to make it clear that your patch follows the Developer Certificat of Origin. See also:


  15 files changed, 639 insertions(+), 639 deletions(-)

I think the patch is rather big already. Could you please split it up in three patches instead:

- One for block/ and include/block
- One for hw/block/ and include/hw/block
- One for hw/ide/ and include/hw/ide

Please also make sure to CC: qemu-block@nongnu.org on these patches (I recommend to use the scripts/get_maintainer.pl script to get the right list of people to put into the CC: list of the patches).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]