[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

From: WANG Xuerui
Subject: Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host
Date: Mon, 27 Sep 2021 10:59:31 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0a1

On 9/27/21 10:42, WANG Xuerui wrote:

On 9/27/21 06:01, Philippe Mathieu-Daudé wrote:
Reported-by: Warner Losh <imp@bsdimp.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
  bsd-user/meson.build | 4 ++++
  1 file changed, 4 insertions(+)

I'm newcomer here, but this is just 4 lines of Meson, and two similar usages already exist within QEMU proper so...

Reviewed-by: WANG Xuerui <git@xen0n.name>

Hmm, other replies pointed out that one can also make the top-level subdir() call conditional... And we seem to have more than 2 usages following the latter pattern instead. However putting the conditional in sub-directory makes the logic localized, which is arguably more friendly to someone casually browsing the source code.

As both ways work, I think maybe being consistent and moving things to top-level meson.build has more value?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]