[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/sparc: Make sparc_cpu_dump_state() static

From: Mark Cave-Ayland
Subject: Re: [PATCH] target/sparc: Make sparc_cpu_dump_state() static
Date: Thu, 16 Sep 2021 11:51:48 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 16/09/2021 09:40, Philippe Mathieu-Daudé wrote:

The sparc_cpu_dump_state() function is only called within
the same file. Make it static.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
  target/sparc/cpu.h | 1 -
  target/sparc/cpu.c | 2 +-
  2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h
index ff8ae73002a..1f40d768d8b 100644
--- a/target/sparc/cpu.h
+++ b/target/sparc/cpu.h
@@ -571,7 +571,6 @@ extern const VMStateDescription vmstate_sparc_cpu;
void sparc_cpu_do_interrupt(CPUState *cpu);
-void sparc_cpu_dump_state(CPUState *cpu, FILE *f, int flags);
  hwaddr sparc_cpu_get_phys_page_debug(CPUState *cpu, vaddr addr);
  int sparc_cpu_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg);
  int sparc_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);
diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index 5a8a4ce7506..21dd27796d0 100644
--- a/target/sparc/cpu.c
+++ b/target/sparc/cpu.c
@@ -612,7 +612,7 @@ static void cpu_print_cc(FILE *f, uint32_t cc)
  #define REGS_PER_LINE 8
-void sparc_cpu_dump_state(CPUState *cs, FILE *f, int flags)
+static void sparc_cpu_dump_state(CPUState *cs, FILE *f, int flags)
      SPARCCPU *cpu = SPARC_CPU(cs);
      CPUSPARCState *env = &cpu->env;

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]