[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/avr: Fix compiler errors (-Werror=enum-conversion)
From: |
Laurent Vivier |
Subject: |
Re: [PATCH] target/avr: Fix compiler errors (-Werror=enum-conversion) |
Date: |
Thu, 16 Sep 2021 12:11:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
Le 06/07/2021 à 20:09, Stefan Weil a écrit :
> ../target/avr/translate.c: In function ‘gen_jmp_ez’:
> ../target/avr/translate.c:1012:22: error: implicit conversion from ‘enum
> <anonymous>’ to ‘DisasJumpType’ [-Werror=enum-conversion]
> 1012 | ctx->base.is_jmp = DISAS_LOOKUP;
> | ^
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> -Werror=enum-conversion is not enabled by -Wall, but by -Weverything
> with clang for example.
>
> As other targets use similar define statements, I think that's a simple fix.
>
> Regards,
> Stefan
>
>
> target/avr/translate.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/target/avr/translate.c b/target/avr/translate.c
> index c06ce45bc7..fcc839ac36 100644
> --- a/target/avr/translate.c
> +++ b/target/avr/translate.c
> @@ -70,11 +70,9 @@ static const char reg_names[NUMBER_OF_CPU_REGISTERS][8] = {
> };
> #define REG(x) (cpu_r[x])
>
> -enum {
> - DISAS_EXIT = DISAS_TARGET_0, /* We want return to the cpu main loop.
> */
> - DISAS_LOOKUP = DISAS_TARGET_1, /* We have a variable condition exit. */
> - DISAS_CHAIN = DISAS_TARGET_2, /* We have a single condition exit. */
> -};
> +#define DISAS_EXIT DISAS_TARGET_0 /* We want return to the cpu main loop.
> */
> +#define DISAS_LOOKUP DISAS_TARGET_1 /* We have a variable condition exit.
> */
> +#define DISAS_CHAIN DISAS_TARGET_2 /* We have a single condition exit. */
>
> typedef struct DisasContext DisasContext;
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] target/avr: Fix compiler errors (-Werror=enum-conversion),
Laurent Vivier <=