qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] util/oslib-win32: Fix fatal assertion in qemu_try_memalign


From: Stefan Weil
Subject: Re: [PATCH] util/oslib-win32: Fix fatal assertion in qemu_try_memalign
Date: Fri, 11 Jun 2021 13:12:26 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2

Am 11.06.21 um 13:06 schrieb Philippe Mathieu-Daudé:

On 6/11/21 12:58 PM, Stefan Weil wrote:
The function is called with alignment == 0 which caused an assertion.
Use the code from oslib_posix.c to fix that regression (introduced
by commit ed6f53f9ca9).

Oops.

Can we replace '(introduced by commit ed6f53f9ca9)' by:
Fixes: ed6f53f9ca9 ("util/oslib: Assert qemu_try_memalign() alignment is
a power of 2")

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Sure, that's fine for me, too. I think the text can be changed without a v2 of the patch.

Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]