qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory
Date: Thu, 3 Jun 2021 15:16:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

Hi Michael,

Could you queue this patch via your 'vhost' tree?

On 5/17/21 3:11 PM, Philippe Mathieu-Daudé wrote:
> Cc'ing qemu-trivial@
> 
> On 5/17/21 2:32 PM, Xie Yongji wrote:
>> The symbol address_space_memory are already declared in
>> include/exec/address-spaces.h. So let's add this header file
>> and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h.
>>
>> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  hw/virtio/vhost-vdpa.c         | 1 +
>>  include/hw/virtio/vhost-vdpa.h | 1 -
>>  2 files changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
>> index 8f2fb9f10b2a..ee51863d280b 100644
>> --- a/hw/virtio/vhost-vdpa.c
>> +++ b/hw/virtio/vhost-vdpa.c
>> @@ -18,6 +18,7 @@
>>  #include "hw/virtio/vhost-backend.h"
>>  #include "hw/virtio/virtio-net.h"
>>  #include "hw/virtio/vhost-vdpa.h"
>> +#include "exec/address-spaces.h"
>>  #include "qemu/main-loop.h"
>>  #include "cpu.h"
>>  #include "trace.h"
>> diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
>> index 28ca65018ed7..ae9ee7adb2d0 100644
>> --- a/include/hw/virtio/vhost-vdpa.h
>> +++ b/include/hw/virtio/vhost-vdpa.h
>> @@ -21,5 +21,4 @@ typedef struct vhost_vdpa {
>>      struct vhost_dev *dev;
>>  } VhostVDPA;
>>  
>> -extern AddressSpace address_space_memory;
>>  #endif
>>
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]