[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Adding ifdefs to call the respective routines only when thei
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled |
|
Date: |
Mon, 24 May 2021 18:53:07 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/24/21 3:56 PM, Swetha Joshi wrote:
From: Swetha <swjoshi@microsoft.com>
Signed-off-by: Swetha <swjoshi@microsoft.com>
What are you trying to accomplish?
That's what belongs in the commit message that you omitted.
+ bool acpi_enabled = false;
+#ifdef CONFIG_ARM_VIRT
bool acpi_enabled = virt_is_acpi_enabled(vms);
Of course this doesn't compile, having declared acpi_enabled twice. So you
have clearly not tested this patch sufficiently.
The cc to qemu-trivial is unwarranted.
r~