[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/virtio: Document *_should_notify() are called within rcu_
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH] hw/virtio: Document *_should_notify() are called within rcu_read_lock() |
Date: |
Sun, 23 May 2021 04:02:50 -0400 |
On Thu, May 20, 2021 at 08:49:00AM +0200, Philippe Mathieu-Daudé wrote:
> Such comments make reviewing this file somehow easier.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
ok but
> ---
> hw/virtio/virtio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index e02544b2df7..2b4c6c4b875 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -2449,6 +2449,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int
> value)
> }
> }
>
> +/* Called within rcu_read_lock(). */
> static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq)
> {
> uint16_t old, new;
> @@ -2485,6 +2486,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool
> wrap,
> return vring_need_event(off, new, old);
> }
>
> +/* Called within rcu_read_lock(). */
> static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq)
> {
> VRingPackedDescEvent e;
one space before */ please, not two.
> --
> 2.26.3