[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 23/23] hw/rx/rx-gdbsim: Do not accept invalid memory size
From: |
Laurent Vivier |
Subject: |
[PULL 23/23] hw/rx/rx-gdbsim: Do not accept invalid memory size |
Date: |
Mon, 3 May 2021 10:36:23 +0200 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
We check the amount of RAM is enough, warn when it is
not, but if so we neglect to bail out. Fix that by
adding the missing exit() call.
Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20210407223056.1870497-1-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/rx/rx-gdbsim.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c
index b52d76b9b681..75d1fec6ca46 100644
--- a/hw/rx/rx-gdbsim.c
+++ b/hw/rx/rx-gdbsim.c
@@ -89,6 +89,7 @@ static void rx_gdbsim_init(MachineState *machine)
char *sz = size_to_str(mc->default_ram_size);
error_report("Invalid RAM size, should be more than %s", sz);
g_free(sz);
+ exit(1);
}
/* Allocate memory space */
--
2.31.1
- [PULL 18/23] Do not include exec/address-spaces.h if it's not really necessary, (continued)
- [PULL 18/23] Do not include exec/address-spaces.h if it's not really necessary, Laurent Vivier, 2021/05/03
- [PULL 16/23] Do not include hw/boards.h if it's not really necessary, Laurent Vivier, 2021/05/03
- [PULL 15/23] Do not include sysemu/sysemu.h if it's not really necessary, Laurent Vivier, 2021/05/03
- [PULL 09/23] hw/usb: Constify VMStateDescription, Laurent Vivier, 2021/05/03
- [PULL 14/23] hw: Do not include qemu/log.h if it is not necessary, Laurent Vivier, 2021/05/03
- [PULL 17/23] Do not include cpu.h if it's not really necessary, Laurent Vivier, 2021/05/03
- [PULL 19/23] mc146818rtc: put it into the 'misc' category, Laurent Vivier, 2021/05/03
- [PULL 21/23] scripts: fix generation update-binfmts templates, Laurent Vivier, 2021/05/03
- [PULL 22/23] docs: More precisely describe memory-backend-*::id's user, Laurent Vivier, 2021/05/03
- [PULL 20/23] docs/system: Document the removal of "compat" property for POWER CPUs, Laurent Vivier, 2021/05/03
- [PULL 23/23] hw/rx/rx-gdbsim: Do not accept invalid memory size,
Laurent Vivier <=
- Re: [PULL 00/23] Trivial branch for 6.1 patches, Peter Maydell, 2021/05/05