Re: [PATCH v2 1/3] hw/lm32/Kconfig: Introduce CONFIG_LM32_EVR for lm32-evr/uclinux boards

[Laurent Vivier]

Le 21/02/2021 à 23:56, Philippe Mathieu-Daudé a écrit :
> We want to be able to use the 'LM32' config for architecture
> specific features. Introduce CONFIG_LM32_EVR to select the
> lm32-evr / lm32-uclinux boards.
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  default-configs/devices/lm32-softmmu.mak | 2 +-
>  hw/lm32/Kconfig                          | 6 +++++-
>  hw/lm32/meson.build                      | 2 +-
>  3 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/default-configs/devices/lm32-softmmu.mak 
> b/default-configs/devices/lm32-softmmu.mak
> index 115b3e34c98..1bce3f6e8b6 100644
> --- a/default-configs/devices/lm32-softmmu.mak
> +++ b/default-configs/devices/lm32-softmmu.mak
> @@ -8,5 +8,5 @@ CONFIG_SEMIHOSTING=y
>  
>  # Boards:
>  #
> -CONFIG_LM32=y
> +CONFIG_LM32_EVR=y
>  CONFIG_MILKYMIST=y
> diff --git a/hw/lm32/Kconfig b/hw/lm32/Kconfig
> index ed2e3060b04..20c36edc402 100644
> --- a/hw/lm32/Kconfig
> +++ b/hw/lm32/Kconfig
> @@ -1,7 +1,6 @@
>  config LM32
>      bool
>      select PTIMER
> -    select PFLASH_CFI02
>  
>  config MILKYMIST
>      bool
> @@ -12,3 +11,8 @@ config MILKYMIST
>      select FRAMEBUFFER
>      select SD
>      select USB_OHCI
> +
> +config LM32_EVR
> +    bool
> +    select LM32
> +    select PFLASH_CFI02
> diff --git a/hw/lm32/meson.build b/hw/lm32/meson.build
> index 8caf0a727ff..42d6f8db3d9 100644
> --- a/hw/lm32/meson.build
> +++ b/hw/lm32/meson.build
> @@ -1,6 +1,6 @@
>  lm32_ss = ss.source_set()
>  # LM32 boards
> -lm32_ss.add(when: 'CONFIG_LM32', if_true: files('lm32_boards.c'))
> +lm32_ss.add(when: 'CONFIG_LM32_EVR', if_true: files('lm32_boards.c'))
>  lm32_ss.add(when: 'CONFIG_MILKYMIST', if_true: files('milkymist.c'))
>  
>  hw_arch += {'lm32': lm32_ss}
> 

Applied to my trivial-patches branch.

Thanks,
Laurent