[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] qtest: delete redundant qtest.h header files

From: Chenqun (kuhn)
Subject: RE: [PATCH] qtest: delete redundant qtest.h header files
Date: Fri, 26 Feb 2021 08:07:31 +0000

> -----Original Message-----
> From: Markus Armbruster [mailto:armbru@redhat.com]
> Sent: Thursday, February 25, 2021 5:08 PM
> To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>
> Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org; lvivier@redhat.com;
> thuth@redhat.com; Zhanghailiang <zhang.zhanghailiang@huawei.com>; ganqixin
> <ganqixin@huawei.com>
> Subject: Re: [PATCH] qtest: delete redundant qtest.h header files
> Chen Qun <kuhn.chenqun@huawei.com> writes:
> > There are 23 files that include the "sysemu/qtest.h", but they do not
> > use any qtest functions.
> >
> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> The subject sounds as if you were deleting file include/sysemu/qtest.h, which
> would be wrong.  You're actually deleting inclusions.  Suggest to say
>     qtest: delete superfluous inclusions of qtest.h
This subject is good to me.  Thanks for your point !
I will change it in v2.

> or
>     delete superfluous #include "sysemu/qtest.h"
> Perhaps the maintainer merging your patch can do that for you.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]