[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] virtio-net: add missing object_unref()

From: Jason Wang
Subject: Re: [PATCH v2 2/3] virtio-net: add missing object_unref()
Date: Thu, 18 Feb 2021 13:57:51 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 2021/2/11 上午1:45, Laurent Vivier wrote:
failover_add_primary() calls qdev_device_add() and doesn't unref
the device. Because of that, when the device is unplugged a reference
is remaining and prevents the cleanup of the object.

This prevents to be able to plugin back the failover primary device,
with errors like:

   (qemu) device_add 
   (qemu) device_del hostdev0

We can check with "info qtree" and "info pci" that the device has been removed, 
and then:

   (qemu) device_add 
   Error: vfio 0000:41:00.0: device is already attached
   (qemu) device_add 
   qemu-kvm: Duplicate ID 'hostdev0' for device

Fixes: 21e8709b29cd ("failover: Remove primary_dev member")
Cc: quintela@redhat.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>

Acked-by: Jason Wang <jasowang@redhat.com>

  hw/net/virtio-net.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 5150f295e8c5..1c5af08dc556 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -862,6 +862,8 @@ static void failover_add_primary(VirtIONet *n, Error **errp)
          dev = qdev_device_add(opts, &err);
          if (err) {
+        } else {
+            object_unref(OBJECT(dev));
      } else {
          error_setg(errp, "Primary device not found");

reply via email to

[Prev in Thread] Current Thread [Next in Thread]