[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] virtio-net: add missing object_unref()

From: Jens Freimann
Subject: Re: [PATCH 2/2] virtio-net: add missing object_unref()
Date: Mon, 8 Feb 2021 09:45:14 +0100

On Sat, Feb 06, 2021 at 01:39:55PM +0100, Laurent Vivier wrote:
failover_add_primary() calls qdev_device_add() and doesn't unref
the device. Because of that, when the device is unplugged a reference
is remaining and prevents the cleanup of the object.

This prevents to be able to plugin back the failover primary device,
with errors like:

 (qemu) device_add 
 (qemu) device_del hostdev0

We can check with "info qtree" and "info pci" that the device has been removed, 
and then:

 (qemu) device_add 
 Error: vfio 0000:41:00.0: device is already attached
 (qemu) device_add 
 qemu-kvm: Duplicate ID 'hostdev0' for device

Fixes: 21e8709b29cd ("failover: Remove primary_dev member")
Cc: quintela@redhat.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
hw/net/virtio-net.c | 2 ++
1 file changed, 2 insertions(+)

Reviewed-by: Jens Freimann <jfreimann@redhat.com>

Thank you Laurent!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]