qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/1] /net/tap.c: Fix a memory leak Close fd before returning. Bug


From: ruc_gongyuanjun
Subject: [PATCH 1/1] /net/tap.c: Fix a memory leak Close fd before returning. Buglink: https://bugs.launchpad.net/qemu/+bug/1904486
Date: Wed, 18 Nov 2020 10:07:03 +0800

From: yuanjungong <ruc_gongyuanjun@163.com>

Signed-off-by: yuanjungong <ruc_gongyuanjun@163.com>
---
 net/tap.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/tap.c b/net/tap.c
index c46ff66..fe95fa7 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -817,6 +817,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
         if (ret < 0) {
             error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d",
                              name, fd);
+            close(fd);
             return -1;
         }
 
@@ -831,6 +832,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
                          vhostfdname, vnet_hdr, fd, &err);
         if (err) {
             error_propagate(errp, err);
+            close(fd);
             return -1;
         }
     } else if (tap->has_fds) {
-- 
2.17.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]