qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fpu/softfloat.c: add spaces around operator


From: no-reply
Subject: Re: [PATCH] fpu/softfloat.c: add spaces around operator
Date: Sat, 14 Nov 2020 05:15:48 -0800 (PST)

Patchew URL: 
20201114130715.1126922-1-zhangxinhao1@huawei.com/">https://patchew.org/QEMU/20201114130715.1126922-1-zhangxinhao1@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20201114130715.1126922-1-zhangxinhao1@huawei.com
Type: series
Subject: [PATCH] fpu/softfloat.c: add spaces around operator

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201113183312.432630-1-michael.roth@amd.com -> 
patchew/20201113183312.432630-1-michael.roth@amd.com
 * [new tag]         patchew/20201114130715.1126922-1-zhangxinhao1@huawei.com 
-> patchew/20201114130715.1126922-1-zhangxinhao1@huawei.com
Switched to a new branch 'test'
16278b7 fpu/softfloat.c: add spaces around operator

=== OUTPUT BEGIN ===
ERROR: space prohibited after that open parenthesis '('
#22: FILE: fpu/softfloat.c:3789:
+    absZ = ( absZ + roundIncrement ) >> 7;

ERROR: space prohibited before that close parenthesis ')'
#22: FILE: fpu/softfloat.c:3789:
+    absZ = ( absZ + roundIncrement ) >> 7;

ERROR: space prohibited after that open parenthesis '('
#29: FILE: fpu/softfloat.c:3795:
+    if ( ( absZ >> 32 ) || ( z && ( ( z < 0 ) ^ zSign ) ) ) {

ERROR: space prohibited before that close parenthesis ')'
#29: FILE: fpu/softfloat.c:3795:
+    if ( ( absZ >> 32 ) || ( z && ( ( z < 0 ) ^ zSign ) ) ) {

ERROR: space prohibited after that open parenthesis '('
#47: FILE: fpu/softfloat.c:4036:
+    zSig = ( zSig + roundIncrement ) >> 7;

ERROR: space prohibited before that close parenthesis ')'
#47: FILE: fpu/softfloat.c:4036:
+    zSig = ( zSig + roundIncrement ) >> 7;

ERROR: space prohibited after that open parenthesis '('
#74: FILE: fpu/softfloat.c:4099:
+        ( ( (uint64_t) zSign ) << 63 ) + ( ( (uint64_t) zExp ) << 52 ) + zSig);

ERROR: space prohibited before that close parenthesis ')'
#74: FILE: fpu/softfloat.c:4099:
+        ( ( (uint64_t) zSign ) << 63 ) + ( ( (uint64_t) zExp ) << 52 ) + zSig);

ERROR: space prohibited after that open parenthesis '('
#83: FILE: fpu/softfloat.c:4192:
+    zSig = ( zSig + roundIncrement ) >> 10;

ERROR: space prohibited before that close parenthesis ')'
#83: FILE: fpu/softfloat.c:4192:
+    zSig = ( zSig + roundIncrement ) >> 10;

ERROR: space prohibited after that open parenthesis '('
#110: FILE: fpu/softfloat.c:4329:
+            if ( roundNearestEven && ( roundBits << 1 == roundIncrement ) ) {

ERROR: space prohibited before that close parenthesis ')'
#110: FILE: fpu/softfloat.c:4329:
+            if ( roundNearestEven && ( roundBits << 1 == roundIncrement ) ) {

ERROR: space prohibited after that open parenthesis '('
#119: FILE: fpu/softfloat.c:4345:
+    if ( roundNearestEven && ( roundBits << 1 == roundIncrement ) ) {

ERROR: space prohibited before that close parenthesis ')'
#119: FILE: fpu/softfloat.c:4345:
+    if ( roundNearestEven && ( roundBits << 1 == roundIncrement ) ) {

ERROR: space prohibited after that open parenthesis '('
#128: FILE: fpu/softfloat.c:4512:
+    return ( a.high >> 48 ) & 0x7FFF;

ERROR: space prohibited before that close parenthesis ')'
#128: FILE: fpu/softfloat.c:4512:
+    return ( a.high >> 48 ) & 0x7FFF;

ERROR: space prohibited after that '-' (ctx:WxW)
#138: FILE: fpu/softfloat.c:4549:
+            *zSig0Ptr = aSig1 >> ( - shiftCount );
                                    ^

ERROR: space prohibited after that open parenthesis '('
#138: FILE: fpu/softfloat.c:4549:
+            *zSig0Ptr = aSig1 >> ( - shiftCount );

ERROR: space prohibited before that close parenthesis ')'
#138: FILE: fpu/softfloat.c:4549:
+            *zSig0Ptr = aSig1 >> ( - shiftCount );

ERROR: space prohibited after that open parenthesis '('
#139: FILE: fpu/softfloat.c:4550:
+            *zSig1Ptr = aSig1 << ( shiftCount & 63 );

ERROR: space prohibited before that close parenthesis ')'
#139: FILE: fpu/softfloat.c:4550:
+            *zSig1Ptr = aSig1 << ( shiftCount & 63 );

ERROR: space prohibited after that open parenthesis '('
#152: FILE: fpu/softfloat.c:4778:
+    return packFloatx80( zSign, 0x403E - shiftCount, zSig << shiftCount );

ERROR: space prohibited before that close parenthesis ')'
#152: FILE: fpu/softfloat.c:4778:
+    return packFloatx80( zSign, 0x403E - shiftCount, zSig << shiftCount );

ERROR: space prohibited after that open parenthesis '('
#161: FILE: fpu/softfloat.c:4800:
+    return packFloat128( zSign, 0x402E - shiftCount, zSig0 << shiftCount, 0 );

ERROR: space prohibited before that close parenthesis ')'
#161: FILE: fpu/softfloat.c:4800:
+    return packFloat128( zSign, 0x402E - shiftCount, zSig0 << shiftCount, 0 );

ERROR: space prohibited after that open parenthesis '('
#170: FILE: fpu/softfloat.c:4821:
+    return packFloatx80( zSign, 0x403E - shiftCount, absA << shiftCount );

ERROR: space prohibited before that close parenthesis ')'
#170: FILE: fpu/softfloat.c:4821:
+    return packFloatx80( zSign, 0x403E - shiftCount, absA << shiftCount );

ERROR: space prohibited after that open parenthesis '('
#179: FILE: fpu/softfloat.c:4904:
+    return packFloatx80( aSign, aExp + 0x3F80, ( (uint64_t) aSig ) << 40 );

ERROR: space prohibited before that close parenthesis ')'
#179: FILE: fpu/softfloat.c:4904:
+    return packFloatx80( aSign, aExp + 0x3F80, ( (uint64_t) aSig ) << 40 );

ERROR: space prohibited after that open parenthesis '('
#188: FILE: fpu/softfloat.c:4936:
+    return packFloat128( aSign, aExp + 0x3F80, ( (uint64_t) aSig ) << 25, 0 );

ERROR: space prohibited before that close parenthesis ')'
#188: FILE: fpu/softfloat.c:4936:
+    return packFloat128( aSign, aExp + 0x3F80, ( (uint64_t) aSig ) << 25, 0 );

ERROR: space prohibited after that open parenthesis '('
#197: FILE: fpu/softfloat.c:5000:
+            q = ( ( (uint64_t) aSig ) << 32 ) / bSig;

ERROR: space prohibited before that close parenthesis ')'
#197: FILE: fpu/softfloat.c:5000:
+            q = ( ( (uint64_t) aSig ) << 32 ) / bSig;

ERROR: space prohibited after that open parenthesis '('
#201: FILE: fpu/softfloat.c:5003:
+            aSig = ( ( aSig >> 1 ) << ( expDiff - 1 ) ) - bSig * q;

ERROR: space prohibited before that close parenthesis ')'
#201: FILE: fpu/softfloat.c:5003:
+            aSig = ( ( aSig >> 1 ) << ( expDiff - 1 ) ) - bSig * q;

ERROR: space prohibited after that open parenthesis '('
#211: FILE: fpu/softfloat.c:5012:
+        aSig64 = ( (uint64_t) aSig ) << 40;

ERROR: space prohibited before that close parenthesis ')'
#211: FILE: fpu/softfloat.c:5012:
+        aSig64 = ( (uint64_t) aSig ) << 40;

ERROR: space prohibited after that open parenthesis '('
#212: FILE: fpu/softfloat.c:5013:
+        bSig64 = ( (uint64_t) bSig ) << 40;

ERROR: space prohibited before that close parenthesis ')'
#212: FILE: fpu/softfloat.c:5013:
+        bSig64 = ( (uint64_t) bSig ) << 40;

ERROR: space prohibited after that '-' (ctx:WxW)
#218: FILE: fpu/softfloat.c:5018:
+            aSig64 = - ( ( bSig * q64 ) << 38 );
                      ^

ERROR: space prohibited after that open parenthesis '('
#218: FILE: fpu/softfloat.c:5018:
+            aSig64 = - ( ( bSig * q64 ) << 38 );

ERROR: space prohibited before that close parenthesis ')'
#218: FILE: fpu/softfloat.c:5018:
+            aSig64 = - ( ( bSig * q64 ) << 38 );

ERROR: space prohibited after that open parenthesis '('
#225: FILE: fpu/softfloat.c:5024:
+        q = q64 >> ( 64 - expDiff );

ERROR: space prohibited before that close parenthesis ')'
#225: FILE: fpu/softfloat.c:5024:
+        q = q64 >> ( 64 - expDiff );

ERROR: space prohibited after that open parenthesis '('
#228: FILE: fpu/softfloat.c:5026:
+        aSig = ( ( aSig64 >> 33 ) << ( expDiff - 1 ) ) - bSig * q;

ERROR: space prohibited before that close parenthesis ')'
#228: FILE: fpu/softfloat.c:5026:
+        aSig = ( ( aSig64 >> 33 ) << ( expDiff - 1 ) ) - bSig * q;

ERROR: space prohibited after that '-' (ctx:WxW)
#237: FILE: fpu/softfloat.c:5305:
+        aSig = - ( ( bSig >> 2 ) * q );
                ^

ERROR: space prohibited after that open parenthesis '('
#237: FILE: fpu/softfloat.c:5305:
+        aSig = - ( ( bSig >> 2 ) * q );

ERROR: space prohibited before that close parenthesis ')'
#237: FILE: fpu/softfloat.c:5305:
+        aSig = - ( ( bSig >> 2 ) * q );

ERROR: space prohibited after that open parenthesis '('
#246: FILE: fpu/softfloat.c:5314:
+        aSig = ( ( aSig >> 1 ) << ( expDiff - 1 ) ) - bSig * q;

ERROR: space prohibited before that close parenthesis ')'
#246: FILE: fpu/softfloat.c:5314:
+        aSig = ( ( aSig >> 1 ) << ( expDiff - 1 ) ) - bSig * q;

ERROR: space prohibited after that open parenthesis '('
#255: FILE: fpu/softfloat.c:5407:
+    if ( ( aExp == 0x7FFF ) && (uint64_t) ( aSig << 1 ) ) aSign = 0;

ERROR: space prohibited before that close parenthesis ')'
#255: FILE: fpu/softfloat.c:5407:
+    if ( ( aExp == 0x7FFF ) && (uint64_t) ( aSig << 1 ) ) aSign = 0;

ERROR: trailing statements should be on next line
#255: FILE: fpu/softfloat.c:5407:
+    if ( ( aExp == 0x7FFF ) && (uint64_t) ( aSig << 1 ) ) aSign = 0;

ERROR: braces {} are necessary for all arms of this statement
#255: FILE: fpu/softfloat.c:5407:
+    if ( ( aExp == 0x7FFF ) && (uint64_t) ( aSig << 1 ) ) aSign = 0;
[...]

ERROR: space prohibited after that open parenthesis '('
#264: FILE: fpu/softfloat.c:5440:
+        if ( ( aExp == 0x7FFF ) && (uint64_t) ( aSig << 1 ) ) aSign = 0;

ERROR: space prohibited before that close parenthesis ')'
#264: FILE: fpu/softfloat.c:5440:
+        if ( ( aExp == 0x7FFF ) && (uint64_t) ( aSig << 1 ) ) aSign = 0;

ERROR: trailing statements should be on next line
#264: FILE: fpu/softfloat.c:5440:
+        if ( ( aExp == 0x7FFF ) && (uint64_t) ( aSig << 1 ) ) aSign = 0;

ERROR: braces {} are necessary for all arms of this statement
#264: FILE: fpu/softfloat.c:5440:
+        if ( ( aExp == 0x7FFF ) && (uint64_t) ( aSig << 1 ) ) aSign = 0;
[...]

ERROR: space prohibited after that open parenthesis '('
#273: FILE: fpu/softfloat.c:5459:
+    if ( ( aSig << shiftCount ) != savedASig ) {

ERROR: space prohibited before that close parenthesis ')'
#273: FILE: fpu/softfloat.c:5459:
+    if ( ( aSig << shiftCount ) != savedASig ) {

ERROR: space prohibited after that '-' (ctx:WxW)
#283: FILE: fpu/softfloat.c:5548:
+    z = aSig >> ( - shiftCount );
                   ^

ERROR: space prohibited after that open parenthesis '('
#283: FILE: fpu/softfloat.c:5548:
+    z = aSig >> ( - shiftCount );

ERROR: space prohibited before that close parenthesis ')'
#283: FILE: fpu/softfloat.c:5548:
+    z = aSig >> ( - shiftCount );

ERROR: space prohibited after that open parenthesis '('
#284: FILE: fpu/softfloat.c:5549:
+    if ( (uint64_t) ( aSig << ( shiftCount & 63 ) ) ) {

ERROR: space prohibited before that close parenthesis ')'
#284: FILE: fpu/softfloat.c:5549:
+    if ( (uint64_t) ( aSig << ( shiftCount & 63 ) ) ) {

ERROR: space prohibited after that open parenthesis '('
#293: FILE: fpu/softfloat.c:5578:
+        if ( (uint64_t) ( aSig << 1 ) ) {

ERROR: space prohibited before that close parenthesis ')'
#293: FILE: fpu/softfloat.c:5578:
+        if ( (uint64_t) ( aSig << 1 ) ) {

ERROR: space prohibited after that open parenthesis '('
#302: FILE: fpu/softfloat.c:5612:
+        if ( (uint64_t) ( aSig << 1 ) ) {

ERROR: space prohibited before that close parenthesis ')'
#302: FILE: fpu/softfloat.c:5612:
+        if ( (uint64_t) ( aSig << 1 ) ) {

ERROR: space prohibited after that open parenthesis '('
#311: FILE: fpu/softfloat.c:5645:
+    if ( ( aExp == 0x7FFF ) && (uint64_t) ( aSig << 1 ) ) {

ERROR: space prohibited before that close parenthesis ')'
#311: FILE: fpu/softfloat.c:5645:
+    if ( ( aExp == 0x7FFF ) && (uint64_t) ( aSig << 1 ) ) {

ERROR: space prohibited after that open parenthesis '('
#317: FILE: fpu/softfloat.c:5650:
+    shift128Right( aSig << 1, 0, 16, &zSig0, &zSig1 );

ERROR: space prohibited before that close parenthesis ')'
#317: FILE: fpu/softfloat.c:5650:
+    shift128Right( aSig << 1, 0, 16, &zSig0, &zSig1 );

WARNING: line over 80 characters
#326: FILE: fpu/softfloat.c:5691:
+        if ( ( aExp == 0x7FFF ) && (uint64_t) ( extractFloatx80Frac( a ) << 1 
) ) {

ERROR: space prohibited after that open parenthesis '('
#326: FILE: fpu/softfloat.c:5691:
+        if ( ( aExp == 0x7FFF ) && (uint64_t) ( extractFloatx80Frac( a ) << 1 
) ) {

ERROR: space prohibited before that close parenthesis ')'
#326: FILE: fpu/softfloat.c:5691:
+        if ( ( aExp == 0x7FFF ) && (uint64_t) ( extractFloatx80Frac( a ) << 1 
) ) {

WARNING: line over 80 characters
#335: FILE: fpu/softfloat.c:5705:
+            if ( ( aExp == 0x3FFE ) && (uint64_t) ( extractFloatx80Frac( a ) 
<< 1 )

ERROR: space prohibited after that open parenthesis '('
#335: FILE: fpu/softfloat.c:5705:
+            if ( ( aExp == 0x3FFE ) && (uint64_t) ( extractFloatx80Frac( a ) 
<< 1 )

ERROR: space prohibited before that close parenthesis ')'
#335: FILE: fpu/softfloat.c:5705:
+            if ( ( aExp == 0x3FFE ) && (uint64_t) ( extractFloatx80Frac( a ) 
<< 1 )

ERROR: space prohibited after that open parenthesis '('
#353: FILE: fpu/softfloat.c:5820:
+            if ( (uint64_t) ( ( aSig | bSig ) << 1 ) ) {

ERROR: space prohibited before that close parenthesis ')'
#353: FILE: fpu/softfloat.c:5820:
+            if ( (uint64_t) ( ( aSig | bSig ) << 1 ) ) {

ERROR: space prohibited after that open parenthesis '('
#362: FILE: fpu/softfloat.c:5877:
+        if ( (uint64_t) ( ( aSig | bSig ) << 1 ) ) {

ERROR: space prohibited before that close parenthesis ')'
#362: FILE: fpu/softfloat.c:5877:
+        if ( (uint64_t) ( ( aSig | bSig ) << 1 ) ) {

ERROR: space prohibited after that open parenthesis '('
#372: FILE: fpu/softfloat.c:5997:
+        if (    (uint64_t) ( aSig << 1 )

ERROR: space prohibited before that close parenthesis ')'
#372: FILE: fpu/softfloat.c:5997:
+        if (    (uint64_t) ( aSig << 1 )

ERROR: space prohibited after that open parenthesis '('
#373: FILE: fpu/softfloat.c:5998:
+             || ( ( bExp == 0x7FFF ) && (uint64_t) ( bSig << 1 ) ) ) {

ERROR: space prohibited before that close parenthesis ')'
#373: FILE: fpu/softfloat.c:5998:
+             || ( ( bExp == 0x7FFF ) && (uint64_t) ( bSig << 1 ) ) ) {

ERROR: space prohibited after that open parenthesis '('
#382: FILE: fpu/softfloat.c:6109:
+    if ( (uint64_t) ( zSig1 << 1 ) <= 8 ) {

ERROR: space prohibited before that close parenthesis ')'
#382: FILE: fpu/softfloat.c:6109:
+    if ( (uint64_t) ( zSig1 << 1 ) <= 8 ) {

ERROR: space prohibited after that open parenthesis '('
#392: FILE: fpu/softfloat.c:6150:
+        if (    (uint64_t) ( aSig0 << 1 )

ERROR: space prohibited before that close parenthesis ')'
#392: FILE: fpu/softfloat.c:6150:
+        if (    (uint64_t) ( aSig0 << 1 )

ERROR: space prohibited after that open parenthesis '('
#393: FILE: fpu/softfloat.c:6151:
+             || ( ( bExp == 0x7FFF ) && (uint64_t) ( bSig << 1 ) ) ) {

ERROR: space prohibited before that close parenthesis ')'
#393: FILE: fpu/softfloat.c:6151:
+             || ( ( bExp == 0x7FFF ) && (uint64_t) ( bSig << 1 ) ) ) {

ERROR: space prohibited after that open parenthesis '('
#402: FILE: fpu/softfloat.c:6216:
+        mul64To128( bSig, q << ( 64 - expDiff ), &term0, &term1 );

ERROR: space prohibited before that close parenthesis ')'
#402: FILE: fpu/softfloat.c:6216:
+        mul64To128( bSig, q << ( 64 - expDiff ), &term0, &term1 );

ERROR: space prohibited after that open parenthesis '('
#412: FILE: fpu/softfloat.c:6313:
+    zExp = ( ( aExp - 0x3FFF ) >> 1 ) + 0x3FFF;

ERROR: space prohibited before that close parenthesis ')'
#412: FILE: fpu/softfloat.c:6313:
+    zExp = ( ( aExp - 0x3FFF ) >> 1 ) + 0x3FFF;

ERROR: space prohibited after that open parenthesis '('
#413: FILE: fpu/softfloat.c:6314:
+    zSig0 = estimateSqrt32( aExp, aSig0 >> 32 );

ERROR: space prohibited before that close parenthesis ')'
#413: FILE: fpu/softfloat.c:6314:
+    zSig0 = estimateSqrt32( aExp, aSig0 >> 32 );

ERROR: space prohibited after that open parenthesis '('
#417: FILE: fpu/softfloat.c:6316:
+    zSig0 = estimateDiv128To64( aSig0, aSig1, zSig0 << 32 ) + ( zSig0 << 30 );

ERROR: space prohibited before that close parenthesis ')'
#417: FILE: fpu/softfloat.c:6316:
+    zSig0 = estimateDiv128To64( aSig0, aSig1, zSig0 << 32 ) + ( zSig0 << 30 );

ERROR: space prohibited after that open parenthesis '('
#425: FILE: fpu/softfloat.c:6323:
+        add128( rem0, rem1, zSig0 >> 63, doubleZSig0 | 1, &rem0, &rem1 );

ERROR: space prohibited before that close parenthesis ')'
#425: FILE: fpu/softfloat.c:6323:
+        add128( rem0, rem1, zSig0 >> 63, doubleZSig0 | 1, &rem0, &rem1 );

ERROR: space prohibited after that open parenthesis '('
#434: FILE: fpu/softfloat.c:6419:
+    if ( ( aSig0 << shiftCount ) != savedASig ) {

ERROR: space prohibited before that close parenthesis ')'
#434: FILE: fpu/softfloat.c:6419:
+    if ( ( aSig0 << shiftCount ) != savedASig ) {

ERROR: space prohibited after that '-' (ctx:WxW)
#444: FILE: fpu/softfloat.c:6509:
+        z = ( aSig0 << shiftCount ) | ( aSig1 >> ( ( - shiftCount ) & 63 ) );
                                                      ^

ERROR: space prohibited after that open parenthesis '('
#444: FILE: fpu/softfloat.c:6509:
+        z = ( aSig0 << shiftCount ) | ( aSig1 >> ( ( - shiftCount ) & 63 ) );

ERROR: space prohibited before that close parenthesis ')'
#444: FILE: fpu/softfloat.c:6509:
+        z = ( aSig0 << shiftCount ) | ( aSig1 >> ( ( - shiftCount ) & 63 ) );

ERROR: space prohibited after that open parenthesis '('
#445: FILE: fpu/softfloat.c:6510:
+        if ( (uint64_t) ( aSig1 << shiftCount ) ) {

ERROR: space prohibited before that close parenthesis ')'
#445: FILE: fpu/softfloat.c:6510:
+        if ( (uint64_t) ( aSig1 << shiftCount ) ) {

ERROR: space prohibited after that '-' (ctx:WxW)
#454: FILE: fpu/softfloat.c:6521:
+        z = aSig0 >> ( - shiftCount );
                        ^

ERROR: space prohibited after that open parenthesis '('
#454: FILE: fpu/softfloat.c:6521:
+        z = aSig0 >> ( - shiftCount );

ERROR: space prohibited before that close parenthesis ')'
#454: FILE: fpu/softfloat.c:6521:
+        z = aSig0 >> ( - shiftCount );

WARNING: line over 80 characters
#457: FILE: fpu/softfloat.c:6523:
+             || ( shiftCount && (uint64_t) ( aSig0 << ( shiftCount & 63 ) ) ) 
) {

ERROR: space prohibited after that open parenthesis '('
#457: FILE: fpu/softfloat.c:6523:
+             || ( shiftCount && (uint64_t) ( aSig0 << ( shiftCount & 63 ) ) ) 
) {

ERROR: space prohibited before that close parenthesis ')'
#457: FILE: fpu/softfloat.c:6523:
+             || ( shiftCount && (uint64_t) ( aSig0 << ( shiftCount & 63 ) ) ) 
) {

ERROR: space prohibited after that open parenthesis '('
#466: FILE: fpu/softfloat.c:6779:
+        lastBitMask = ( lastBitMask << ( 0x406E - aExp ) ) << 1;

ERROR: space prohibited before that close parenthesis ')'
#466: FILE: fpu/softfloat.c:6779:
+        lastBitMask = ( lastBitMask << ( 0x406E - aExp ) ) << 1;

ERROR: space prohibited after that open parenthesis '('
#473: FILE: fpu/softfloat.c:6785:
+                add128( z.high, z.low, 0, lastBitMask >> 1, &z.high, &z.low );

ERROR: space prohibited before that close parenthesis ')'
#473: FILE: fpu/softfloat.c:6785:
+                add128( z.high, z.low, 0, lastBitMask >> 1, &z.high, &z.low );

ERROR: space prohibited after that open parenthesis '('
#480: FILE: fpu/softfloat.c:6791:
+                    if ( (uint64_t) ( z.low << 1 ) == 0 ) z.high &= ~1;

ERROR: space prohibited before that close parenthesis ')'
#480: FILE: fpu/softfloat.c:6791:
+                    if ( (uint64_t) ( z.low << 1 ) == 0 ) z.high &= ~1;

ERROR: trailing statements should be on next line
#480: FILE: fpu/softfloat.c:6791:
+                    if ( (uint64_t) ( z.low << 1 ) == 0 ) z.high &= ~1;

ERROR: braces {} are necessary for all arms of this statement
#480: FILE: fpu/softfloat.c:6791:
+                    if ( (uint64_t) ( z.low << 1 ) == 0 ) z.high &= ~1;
[...]

ERROR: space prohibited after that open parenthesis '('
#489: FILE: fpu/softfloat.c:6832:
+            if ( ( ( (uint64_t) ( a.high << 1 ) ) | a.low ) == 0 ) return a;

ERROR: space prohibited before that close parenthesis ')'
#489: FILE: fpu/softfloat.c:6832:
+            if ( ( ( (uint64_t) ( a.high << 1 ) ) | a.low ) == 0 ) return a;

ERROR: trailing statements should be on next line
#489: FILE: fpu/softfloat.c:6832:
+            if ( ( ( (uint64_t) ( a.high << 1 ) ) | a.low ) == 0 ) return a;

ERROR: braces {} are necessary for all arms of this statement
#489: FILE: fpu/softfloat.c:6832:
+            if ( ( ( (uint64_t) ( a.high << 1 ) ) | a.low ) == 0 ) return a;
[...]

ERROR: space prohibited after that open parenthesis '('
#514: FILE: fpu/softfloat.c:7425:
+    zExp = ( ( aExp - 0x3FFF ) >> 1 ) + 0x3FFE;

ERROR: space prohibited before that close parenthesis ')'
#514: FILE: fpu/softfloat.c:7425:
+    zExp = ( ( aExp - 0x3FFF ) >> 1 ) + 0x3FFE;

ERROR: space prohibited after that open parenthesis '('
#517: FILE: fpu/softfloat.c:7427:
+    zSig0 = estimateSqrt32( aExp, aSig0 >> 17 );

ERROR: space prohibited before that close parenthesis ')'
#517: FILE: fpu/softfloat.c:7427:
+    zSig0 = estimateSqrt32( aExp, aSig0 >> 17 );

ERROR: space prohibited after that open parenthesis '('
#521: FILE: fpu/softfloat.c:7429:
+    zSig0 = estimateDiv128To64( aSig0, aSig1, zSig0 << 32 ) + ( zSig0 << 30 );

ERROR: space prohibited before that close parenthesis ')'
#521: FILE: fpu/softfloat.c:7429:
+    zSig0 = estimateDiv128To64( aSig0, aSig1, zSig0 << 32 ) + ( zSig0 << 30 );

ERROR: space prohibited after that open parenthesis '('
#529: FILE: fpu/softfloat.c:7436:
+        add128( rem0, rem1, zSig0 >> 63, doubleZSig0 | 1, &rem0, &rem1 );

ERROR: space prohibited before that close parenthesis ')'
#529: FILE: fpu/softfloat.c:7436:
+        add128( rem0, rem1, zSig0 >> 63, doubleZSig0 | 1, &rem0, &rem1 );

ERROR: space prohibited after that open parenthesis '('
#538: FILE: fpu/softfloat.c:7470:
+          ( extractFloatx80Frac( a ) << 1 ) ) ||

ERROR: space prohibited before that close parenthesis ')'
#538: FILE: fpu/softfloat.c:7470:
+          ( extractFloatx80Frac( a ) << 1 ) ) ||

ERROR: space prohibited after that open parenthesis '('
#541: FILE: fpu/softfloat.c:7472:
+          ( extractFloatx80Frac( b ) << 1 ) )) {

ERROR: space prohibited before that close parenthesis ')'
#541: FILE: fpu/softfloat.c:7472:
+          ( extractFloatx80Frac( b ) << 1 ) )) {

ERROR: space prohibited after that open parenthesis '('
#550: FILE: fpu/softfloat.c:7538:
+        if ( ( ( ( a.high | b.high ) << 1 ) | a.low | b.low ) == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#550: FILE: fpu/softfloat.c:7538:
+        if ( ( ( ( a.high | b.high ) << 1 ) | a.low | b.low ) == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#559: FILE: fpu/softfloat.c:7579:
+        if ( aSig << 1 ) {

ERROR: space prohibited before that close parenthesis ')'
#559: FILE: fpu/softfloat.c:7579:
+        if ( aSig << 1 ) {

total: 142 errors, 3 warnings, 497 lines checked

Commit 16278b715204 (fpu/softfloat.c: add spaces around operator) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201114130715.1126922-1-zhangxinhao1@huawei.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201114130715.1126922-1-zhangxinhao1@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

reply via email to

[Prev in Thread] Current Thread [Next in Thread]