[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the c
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code |
Date: |
Fri, 6 Nov 2020 15:08:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 11/6/20 2:39 PM, Peter Maydell wrote:
> On Fri, 6 Nov 2020 at 13:07, Markus Armbruster <armbru@redhat.com> wrote:
>> The current "warn at 80, error at 90" is a compromise. It's the result
>> of a lengthy argument. Why reopen it?
>
> There was some previous discussion under this thread:
> https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg05653.html
>
> which I think is what prompted this patch.
Can we keep the error please? Maybe 132 is the next display logical
limit once we increased the warning from 80 to 100.
I understand hardware evolved, we have larger displays with better
resolution and can fit more characters in a line.
I am a bit wary however functions become heavier (more code into
a single function). Maybe this checkpatch change should go with
a another one warning when a function has more than 80 lines,
excluding comments? (Even 80 is too much for my taste).
Regards,
Phil.
- [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, Gan Qixin, 2020/11/06
- Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, Peter Maydell, 2020/11/06
- Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, Markus Armbruster, 2020/11/06
- Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, Peter Maydell, 2020/11/06
- Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code,
Philippe Mathieu-Daudé <=
- Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, Peter Maydell, 2020/11/06
- Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, Philippe Mathieu-Daudé, 2020/11/06
- Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, Markus Armbruster, 2020/11/06
- Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, Peter Maydell, 2020/11/06
- RE: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, ganqixin, 2020/11/09
- Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, Markus Armbruster, 2020/11/09
- Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code, Peter Maydell, 2020/11/30