Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()

[Alex Bennée]

AlexChen <alex.chen@huawei.com> writes:

> Kindly ping.

Ahh sorry I missed these. Was there a cover letter for the series?

>
> On 2020/10/28 21:45, AlexChen wrote:
>> Close the fd when connect() fails.
>> 
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: AlexChen <alex.chen@huawei.com>
>> ---
>>  contrib/plugins/lockstep.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
>> index a696673dff..319bd44b83 100644
>> --- a/contrib/plugins/lockstep.c
>> +++ b/contrib/plugins/lockstep.c
>> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
>> 
>>      if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
>>          perror("failed to connect");
>> +        close(fd);
>>          return false;
>>      }
>> 


-- 
Alex Bennée