qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V2 02/14] ppc/: fix some comment spelling errors


From: David Gibson
Subject: Re: [PATCH V2 02/14] ppc/: fix some comment spelling errors
Date: Tue, 27 Oct 2020 13:05:18 +1100

On Mon, Oct 26, 2020 at 10:14:00AM +0100, Thomas Huth wrote:
> On 09/10/2020 08.44, zhaolichang wrote:
> > I found that there are many spelling errors in the comments of 
> > qemu/target/ppc.
> > I used spellcheck to check the spelling errors and found some errors in the 
> > folder.
> > 
> > Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> > Reviewed-by: David Edmondson <david.edmondson@oracle.com>

Acked-by: David Gibson <david@gibson.dropbear.id.au>

> > ---
> >  target/ppc/cpu.h                | 6 +++---
> >  target/ppc/excp_helper.c        | 6 +++---
> >  target/ppc/fpu_helper.c         | 2 +-
> >  target/ppc/internal.h           | 2 +-
> >  target/ppc/kvm.c                | 2 +-
> >  target/ppc/machine.c            | 2 +-
> >  target/ppc/mmu-hash64.c         | 2 +-
> >  target/ppc/mmu_helper.c         | 4 ++--
> >  target/ppc/translate_init.c.inc | 2 +-
> >  9 files changed, 14 insertions(+), 14 deletions(-)
> > 
> > diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> > index 766e9c5c26..ba5ebb13fc 100644
> > --- a/target/ppc/cpu.h
> > +++ b/target/ppc/cpu.h
> > @@ -615,7 +615,7 @@ enum {
> >  #define FPSCR_VXCVI  8  /* Floating-point invalid operation exception 
> > (int)  */
> >  #define FPSCR_VE     7  /* Floating-point invalid operation exception 
> > enable */
> >  #define FPSCR_OE     6  /* Floating-point overflow exception enable        
> >   */
> > -#define FPSCR_UE     5  /* Floating-point undeflow exception enable        
> >   */
> > +#define FPSCR_UE     5  /* Floating-point underflow exception enable       
> >    */
> >  #define FPSCR_ZE     4  /* Floating-point zero divide exception enable     
> >   */
> >  #define FPSCR_XE     3  /* Floating-point inexact exception enable         
> >   */
> >  #define FPSCR_NI     2  /* Floating-point non-IEEE mode                    
> >   */
> > @@ -2331,13 +2331,13 @@ enum {
> >      /* Internal hardware exception sources */
> >      PPC_INTERRUPT_DECR,           /* Decrementer exception                
> > */
> >      PPC_INTERRUPT_HDECR,          /* Hypervisor decrementer exception     
> > */
> > -    PPC_INTERRUPT_PIT,            /* Programmable inteval timer interrupt 
> > */
> > +    PPC_INTERRUPT_PIT,            /* Programmable interval timer interrupt 
> > */
> >      PPC_INTERRUPT_FIT,            /* Fixed interval timer interrupt       
> > */
> >      PPC_INTERRUPT_WDT,            /* Watchdog timer interrupt             
> > */
> >      PPC_INTERRUPT_CDOORBELL,      /* Critical doorbell interrupt          
> > */
> >      PPC_INTERRUPT_DOORBELL,       /* Doorbell interrupt                   
> > */
> >      PPC_INTERRUPT_PERFM,          /* Performance monitor interrupt        
> > */
> > -    PPC_INTERRUPT_HMI,            /* Hypervisor Maintainance interrupt    
> > */
> > +    PPC_INTERRUPT_HMI,            /* Hypervisor Maintenance interrupt    */
> >      PPC_INTERRUPT_HDOORBELL,      /* Hypervisor Doorbell interrupt        
> > */
> >      PPC_INTERRUPT_HVIRT,          /* Hypervisor virtualization interrupt  
> > */
> >  };
> > diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> > index a988ba15f4..d7411bcc81 100644
> > --- a/target/ppc/excp_helper.c
> > +++ b/target/ppc/excp_helper.c
> > @@ -231,7 +231,7 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int 
> > excp_model, int excp)
> >      }
> >  
> >      /*
> > -     * Exception targetting modifiers
> > +     * Exception targeting modifiers
> >       *
> >       * LPES0 is supported on POWER7/8/9
> >       * LPES1 is not supported (old iSeries mode)
> > @@ -1015,7 +1015,7 @@ static void ppc_hw_interrupt(CPUPPCState *env)
> >           * This means we will incorrectly execute past the power management
> >           * instruction instead of triggering a reset.
> >           *
> > -         * It generally means a discrepancy between the wakup conditions 
> > in the
> > +         * It generally means a discrepancy between the wakeup conditions 
> > in the
> >           * processor has_work implementation and the logic in this 
> > function.
> >           */
> >          cpu_abort(env_cpu(env),
> > @@ -1191,7 +1191,7 @@ void helper_rfi(CPUPPCState *env)
> >  void helper_rfid(CPUPPCState *env)
> >  {
> >      /*
> > -     * The architeture defines a number of rules for which bits can
> > +     * The architecture defines a number of rules for which bits can
> >       * change but in practice, we handle this in hreg_store_msr()
> >       * which will be called by do_rfi(), so there is no need to filter
> >       * here
> > diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c
> > index ae43b08eb5..9b8c8b70b6 100644
> > --- a/target/ppc/fpu_helper.c
> > +++ b/target/ppc/fpu_helper.c
> > @@ -1804,7 +1804,7 @@ uint32_t helper_efdcmpeq(CPUPPCState *env, uint64_t 
> > op1, uint64_t op2)
> >  
> >  
> >  /*
> > - * VSX_ADD_SUB - VSX floating point add/subract
> > + * VSX_ADD_SUB - VSX floating point add/subtract
> >   *   name  - instruction mnemonic
> >   *   op    - operation (add or sub)
> >   *   nels  - number of elements (1, 2 or 4)
> > diff --git a/target/ppc/internal.h b/target/ppc/internal.h
> > index 15d655b356..b4df127f4a 100644
> > --- a/target/ppc/internal.h
> > +++ b/target/ppc/internal.h
> > @@ -1,5 +1,5 @@
> >  /*
> > - *  PowerPC interal definitions for qemu.
> > + *  PowerPC internal definitions for qemu.
> >   *
> >   * This library is free software; you can redistribute it and/or
> >   * modify it under the terms of the GNU Lesser General Public
> > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> > index d85ba8ffe0..e85ef2ea9e 100644
> > --- a/target/ppc/kvm.c
> > +++ b/target/ppc/kvm.c
> > @@ -487,7 +487,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
> >              /*
> >               * KVM-HV has transactional memory on POWER8 also without
> >               * the KVM_CAP_PPC_HTM extension, so enable it here
> > -             * instead as long as it's availble to userspace on the
> > +             * instead as long as it's available to userspace on the
> >               * host.
> >               */
> >              if (qemu_getauxval(AT_HWCAP2) & PPC_FEATURE2_HAS_HTM) {
> > diff --git a/target/ppc/machine.c b/target/ppc/machine.c
> > index 109d071162..f6a24a9c9a 100644
> > --- a/target/ppc/machine.c
> > +++ b/target/ppc/machine.c
> > @@ -337,7 +337,7 @@ static int cpu_post_load(void *opaque, int version_id)
> >  
> >      /*
> >       * If we're operating in compat mode, we should be ok as long as
> > -     * the destination supports the same compatiblity mode.
> > +     * the destination supports the same compatibility mode.
> >       *
> >       * Otherwise, however, we require that the destination has exactly
> >       * the same CPU model as the source.
> > diff --git a/target/ppc/mmu-hash64.c b/target/ppc/mmu-hash64.c
> > index c31d21e6a9..977b2d1561 100644
> > --- a/target/ppc/mmu-hash64.c
> > +++ b/target/ppc/mmu-hash64.c
> > @@ -883,7 +883,7 @@ int ppc_hash64_handle_mmu_fault(PowerPCCPU *cpu, vaddr 
> > eaddr,
> >      /*
> >       * Note on LPCR usage: 970 uses HID4, but our special variant of
> >       * store_spr copies relevant fields into env->spr[SPR_LPCR].
> > -     * Similarily we filter unimplemented bits when storing into LPCR
> > +     * Similarly we filter unimplemented bits when storing into LPCR
> >       * depending on the MMU version. This code can thus just use the
> >       * LPCR "as-is".
> >       */
> > diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
> > index 8972714775..50aa18a763 100644
> > --- a/target/ppc/mmu_helper.c
> > +++ b/target/ppc/mmu_helper.c
> > @@ -179,7 +179,7 @@ static inline int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx, 
> > target_ulong pte0,
> >              }
> >              /* Compute access rights */
> >              access = pp_check(ctx->key, pp, ctx->nx);
> > -            /* Keep the matching PTE informations */
> > +            /* Keep the matching PTE information */
> >              ctx->raddr = pte1;
> >              ctx->prot = access;
> >              ret = check_prot(ctx->prot, rw, type);
> > @@ -2176,7 +2176,7 @@ void helper_store_sr(CPUPPCState *env, target_ulong 
> > srnum, target_ulong value)
> >          env->sr[srnum] = value;
> >          /*
> >           * Invalidating 256MB of virtual memory in 4kB pages is way
> > -         * longer than flusing the whole TLB.
> > +         * longer than flushing the whole TLB.
> >           */
> >  #if !defined(FLUSH_ALL_TLBS) && 0
> >          {
> > diff --git a/target/ppc/translate_init.c.inc 
> > b/target/ppc/translate_init.c.inc
> > index bb66526280..3e0810fd6d 100644
> > --- a/target/ppc/translate_init.c.inc
> > +++ b/target/ppc/translate_init.c.inc
> > @@ -792,7 +792,7 @@ static void gen_spr_generic(CPUPPCState *env)
> >                   &spr_read_xer, &spr_write_xer,
> >                   &spr_read_xer, &spr_write_xer,
> >                   0x00000000);
> > -    /* Branch contol */
> > +    /* Branch control */
> >      spr_register(env, SPR_LR, "LR",
> >                   &spr_read_lr, &spr_write_lr,
> >                   &spr_read_lr, &spr_write_lr,
> > 
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]