qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 00/10] Fix line over 80 characters warning


From: ganqixin
Subject: RE: [PATCH 00/10] Fix line over 80 characters warning
Date: Tue, 20 Oct 2020 12:24:15 +0000


> -----Original Message-----
> From: Daniel P. Berrangé [mailto:berrange@redhat.com]
> Sent: Tuesday, October 20, 2020 7:14 PM
> To: ganqixin <ganqixin@huawei.com>
> Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org; lvivier@redhat.com;
> peter.maydell@linaro.org; Zhanghailiang <zhang.zhanghailiang@huawei.com>;
> mst@redhat.com; f4bug@amsat.org; alistair.francis@wdc.com; Chenqun
> (kuhn) <kuhn.chenqun@huawei.com>; david@gibson.dropbear.id.au
> Subject: Re: [PATCH 00/10] Fix line over 80 characters warning
> 
> On Tue, Oct 20, 2020 at 04:30:13AM +0800, Gan Qixin wrote:
> > Hi all,
> >     I used scripts/checkpatch.pl to find that many files in the hw
> > directory contain lines with more than 80 characters. Therefore, I
> > splited some lines to fix this warning.
> 
> Do we really need to still fix ourselves to a 80 col limit in the year 2020 ?
> 
> Linux increased their max line length to 100 chars and even set checkpatch.pl
> to not complain about that limit unless --strict is given.
> 
> 80 chars is fine as a "wish list" target, but IMHO the code often benefits 
> more
> from exceeding 80 chars, and not wrapping.
> 

Hi Daniel,
  Yes, you are right! I also found this problem when I try to fix these 
warning. In some cases, the 80-character limit doesn't necessarily make code 
more readable. 

Thanks,
Gan Qixin

> Regards,
> Daniel
> --
> |: https://berrange.com      -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-
> https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-
> https://www.instagram.com/dberrange :|


reply via email to

[Prev in Thread] Current Thread [Next in Thread]