On 15/10/2020 20:46, Philippe Mathieu-Daudé wrote:
> Since v1:
> - Do not remove mem_base in patch 1 (Laurent)
> - Pass MemoryRegion* (new patch)
> - Run check-qtest
>
> Philippe Mathieu-Daudé (2):
> hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument
> hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument
>
> include/hw/rtc/m48t59.h | 5 ++---
> hw/ppc/ppc405_boards.c | 2 +-
> hw/rtc/m48t59.c | 14 +++-----------
> hw/sparc/sun4m.c | 3 ++-
> hw/sparc64/sun4u.c | 7 ++-----
> 5 files changed, 10 insertions(+), 21 deletions(-)
This looks good, and from what you've done here it's only a little more work to
remove m48t59_init() completely. Would you mind if I try this using these patches as
a starting point? :)
I had a look at your previous suggestion, but I have too many in flight series waiting for 5.2, so sure go ahead!