qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] hw/core/qdev-properties-system: Fix pci bus range in set_


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3] hw/core/qdev-properties-system: Fix pci bus range in set_pci_host_devaddr()
Date: Tue, 13 Oct 2020 12:34:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/13/20 11:20 AM, Klaus Herman wrote:
Fixes: bccb20c49df ("hw/core/qdev-properties: Use qemu_strtoul() in 
set_pci_host_devaddr()")
Signed-off-by: Klaus Herman <kherman@inbox.lv>
---
  hw/core/qdev-properties-system.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index 49bdd12..e3dca56 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -903,7 +903,7 @@ static void set_pci_host_devaddr(Object *obj, Visitor *v, 
const char *name,
      bus = val;
p = (char *)e + 1;
-    if (qemu_strtoul(p, &e, 16, &val) < 0 || val > 0x1f || e == p) {
+    if (qemu_strtoul(p, &e, 16, &val) < 0 || val > 0xff || e == p) {

As this is used to check both bus/slot range, I sent a different
approach to fix this issue:
https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg03604.html

          goto inval;
      }
      if (*e == ':') {





reply via email to

[Prev in Thread] Current Thread [Next in Thread]