[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_c
From: |
Pan Nengyuan |
Subject: |
Re: [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup |
Date: |
Sat, 10 Oct 2020 18:54:32 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
ping!
Maybe missed to queue?
On 2020/9/5 8:44, Li Qiang wrote:
> Pan Nengyuan <pannengyuan@huawei.com> 于2020年9月4日周五 下午3:23写道:
>>
>> s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix it.
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
>
> Reviewed-by: Li Qiang <liq3ea@gmail.com>
>
>> ---
>> net/filter-rewriter.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
>> index 1aaad101b6..9ff366d44f 100644
>> --- a/net/filter-rewriter.c
>> +++ b/net/filter-rewriter.c
>> @@ -376,6 +376,8 @@ static void colo_rewriter_cleanup(NetFilterState *nf)
>> filter_rewriter_flush(nf);
>> g_free(s->incoming_queue);
>> }
>> +
>> + g_hash_table_destroy(s->connection_track_table);
>> }
>>
>> static void colo_rewriter_setup(NetFilterState *nf, Error **errp)
>> --
>> 2.18.2
>>
>>
- Re: [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup,
Pan Nengyuan <=