qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] block/blkdebug: fix memory leak


From: Eric Blake
Subject: Re: [PATCH] block/blkdebug: fix memory leak
Date: Fri, 9 Oct 2020 14:56:49 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 10/9/20 2:09 PM, Elena Afanasova wrote:
> Spotted by PVS-Studio
> 
> Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
> ---
>  block/blkdebug.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/block/blkdebug.c b/block/blkdebug.c
> index eecbf3e5c4..54da719dd1 100644
> --- a/block/blkdebug.c
> +++ b/block/blkdebug.c
> @@ -215,6 +215,7 @@ static int add_rule(void *opaque, QemuOpts *opts, Error 
> **errp)
>                                   BLKDEBUG_IO_TYPE__MAX, &local_error);
>          if (local_error) {
>              error_propagate(errp, local_error);
> +            g_free(rule);
>              return -1;
>          }
>          if (iotype != BLKDEBUG_IO_TYPE__MAX) {
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]