Re: [PATCH 1/5] Fixing Lesser GPL version number [1/5]

[Daniel P . Berrangé]

On Fri, Oct 09, 2020 at 06:37:34AM +0000, Chetan Pant wrote:

I'll take the following if you can split them up into a couple of
patches

> ---
>  authz/base.c                               | 2 +-
>  authz/list.c                               | 2 +-
>  authz/listfile.c                           | 2 +-
>  authz/pamacct.c                            | 2 +-
>  authz/simple.c                             | 2 +-

Split these into an "authz" patch.


>  block/crypto.c                             | 2 +-
>  block/crypto.h                             | 2 +-

Split these two into a "crypto" patch.



>  tests/io-channel-helpers.c                 | 2 +-
>  tests/io-channel-helpers.h                 | 2 +-

Split these into an "io" patch.

Also combine with the io/* cleanups in patch 2, and the
tests/test-io-* cleanups later.

>  tests/migration/guestperf-batch.py         | 2 +-
>  tests/migration/guestperf-plot.py          | 2 +-
>  tests/migration/guestperf.py               | 2 +-
>  tests/migration/guestperf/comparison.py    | 2 +-
>  tests/migration/guestperf/engine.py        | 2 +-
>  tests/migration/guestperf/hardware.py      | 2 +-
>  tests/migration/guestperf/plot.py          | 2 +-
>  tests/migration/guestperf/progress.py      | 2 +-
>  tests/migration/guestperf/report.py        | 2 +-
>  tests/migration/guestperf/scenario.py      | 2 +-
>  tests/migration/guestperf/shell.py         | 2 +-
>  tests/migration/guestperf/timings.py       | 2 +-
>  tests/migration/stress.c                   | 2 +-

Split these.

>  tests/test-authz-list.c                    | 2 +-
>  tests/test-authz-listfile.c                | 2 +-
>  tests/test-authz-pam.c                     | 2 +-
>  tests/test-authz-simple.c                  | 2 +-

Include in "authz" patch.

>  tests/test-crypto-afsplit.c                | 2 +-
>  tests/test-crypto-block.c                  | 2 +-
>  tests/test-crypto-cipher.c                 | 2 +-
>  tests/test-crypto-hash.c                   | 2 +-
>  tests/test-crypto-ivgen.c                  | 2 +-
>  tests/test-crypto-secret.c                 | 2 +-
>  tests/test-crypto-xts.c                    | 2 +-

SPlit into a "crypto" patch

>  tests/test-io-channel-buffer.c             | 2 +-
>  tests/test-io-channel-command.c            | 2 +-
>  tests/test-io-channel-file.c               | 2 +-
>  tests/test-io-channel-socket.c             | 2 +-
>  tests/test-io-task.c                       | 2 +-

Include in an "io" patch


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|