Re: [PATCH v8] scripts: Convert qemu-version.sh to qemu-version.py

[no-reply]

Patchew URL: 
20201007194526.1778-1-luoyonggang@gmail.com/">https://patchew.org/QEMU/20201007194526.1778-1-luoyonggang@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201007194526.1778-1-luoyonggang@gmail.com
Subject: [PATCH v8] scripts: Convert qemu-version.sh to qemu-version.py

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201007194526.1778-1-luoyonggang@gmail.com -> 
patchew/20201007194526.1778-1-luoyonggang@gmail.com
Switched to a new branch 'test'
f42b98d scripts: Convert qemu-version.sh to qemu-version.py

=== OUTPUT BEGIN ===
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: line over 90 characters
#59: FILE: scripts/qemu-version.py:21:
+        match_expression = '--match=v\\*' if platform.system() == 'Windows' 
else '--match=v*'

ERROR: line over 90 characters
#61: FILE: scripts/qemu-version.py:23:
+                            stdout=subprocess.PIPE, stderr=subprocess.DEVNULL, 
encoding='utf8', shell=False)

total: 2 errors, 1 warnings, 43 lines checked

Commit f42b98df7ca0 (scripts: Convert qemu-version.sh to qemu-version.py) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201007194526.1778-1-luoyonggang@gmail.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201007194526.1778-1-luoyonggang@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com