qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Simplify the .gitignore file


From: Thomas Huth
Subject: Re: [PATCH] Simplify the .gitignore file
Date: Wed, 9 Sep 2020 09:58:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 08/09/2020 14.50, Eric Blake wrote:
> On 9/7/20 12:42 PM, Thomas Huth wrote:
>> Now that we always do out-of-tree builds (and the in-tree builds are
>> faked via a "build" directory), we can simplify out .gitignore file
> 
> s/out/our/
> 
>> quite a bit.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   .gitignore | 158 -----------------------------------------------------
>>   1 file changed, 158 deletions(-)
>>
> 
> I like the idea.  As Phillipe pointed out, there are still a few files
> that may be created by merely running './configure' or common editor
> droppings or workflow setups that are still worth ignoring, but as most
> of these truly no longer appear during a fresh checkout, it makes sense
> to clean it up.
> 
> Someone who still wants to use 'fake in-tree' builds and creates
> symlinks for themselves will no longer have those symlinks ignored by
> this pruned file, but can edit their own .git/info/exclude file to match
> their preferences.
> 
>> diff --git a/.gitignore b/.gitignore
>> index 4ccb9ed975..bb916594eb 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -1,165 +1,7 @@
>>   /GNUmakefile
>>   /build/
> 
> Our 'fake in-tree' build uses just 'build', but ignoring '/build*/'
> might be wiser to automatically ignore all other variations on the theme
> of a subdirectory per build.

At least I am doing my out-of-tree builds completely outside of the
source tree. I think if someone wants to use directories within the
source tree for this, they can also simply add them to their private
.gitignore / .git/info/exclude file instead, then you're also more
flexible with the naming.

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]