Re: [PATCH 2/5] hw/mips/fuloong2e: Convert pointless error message to an assert()

[chen huacai]

Reviewed-by: Huacai Chen <chenhc@lemote.com>

On Tue, Sep 1, 2020 at 6:41 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Displaying "vt82c686b_init error" doesn't give any hint about why
> this call failed. As this message targets developers and not users,
> replace the pointless error message by a call to assert() which
> will provide more useful information.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/mips/fuloong2e.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c
> index 8ca31e5162c..f28609976bf 100644
> --- a/hw/mips/fuloong2e.c
> +++ b/hw/mips/fuloong2e.c
> @@ -240,10 +240,7 @@ static void vt82c686b_southbridge_init(PCIBus *pci_bus, 
> int slot, qemu_irq intc,
>      PCIDevice *dev;
>
>      isa_bus = vt82c686b_isa_init(pci_bus, PCI_DEVFN(slot, 0));
> -    if (!isa_bus) {
> -        fprintf(stderr, "vt82c686b_init error\n");
> -        exit(1);
> -    }
> +    assert(isa_bus);
>      *p_isa_bus = isa_bus;
>      /* Interrupt controller */
>      /* The 8259 -> IP5  */
> --
> 2.26.2
>
>


-- 
Huacai Chen