Re: [PATCH 11/12] target/sh4: Remove superfluous breaks

[Laurent Vivier]

Le 13/07/2020 à 11:38, Thomas Huth a écrit :
> On 13/07/2020 11.05, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>>
>> Remove superfluous breaks, as there is a "return" before them.
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  target/sh4/translate.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/target/sh4/translate.c b/target/sh4/translate.c
>> index 6192d83..60c863d 100644
>> --- a/target/sh4/translate.c
>> +++ b/target/sh4/translate.c
>> @@ -1542,7 +1542,6 @@ static void _decode_opc(DisasContext * ctx)
>>          tcg_gen_qemu_ld_i32(REG(0), REG(B11_8), ctx->memidx,
>>                              MO_TEUL | MO_UNALN);
>>          return;
>> -        break;
>>      case 0x40e9:                /* movua.l @Rm+,R0 */
>>          CHECK_SH4A
>>          /* Load non-boundary-aligned data */
>> @@ -1550,7 +1549,6 @@ static void _decode_opc(DisasContext * ctx)
>>                              MO_TEUL | MO_UNALN);
>>          tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4);
>>          return;
>> -        break;
>>      case 0x0029:            /* movt Rn */
>>          tcg_gen_mov_i32(REG(B11_8), cpu_sr_t);
>>      return;
>> @@ -1638,7 +1636,6 @@ static void _decode_opc(DisasContext * ctx)
>>          CHECK_SH4A
>>          tcg_gen_mb(TCG_MO_ALL | TCG_BAR_SC);
>>          return;
>> -        break;
>>      case 0x4024:            /* rotcl Rn */
>>      {
>>          TCGv tmp = tcg_temp_new();
>>
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
> 

Applied to my trivial-patches branch.

Thanks,
Laurent