|
From: | Rohit Shinde |
Subject: | Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations |
Date: | Thu, 27 Aug 2020 17:07:30 -0700 |
Rohit Shinde <rohit.shinde12194@gmail.com> writes:
> I am just compiling with cflag set to -Wimplicit-fallthrough. I am using
> gcc.
-Wimplicit-fallthrough is the same as -Wimplicit-fallthrough=3. Our
-code is not prepared for that. What should work is
--Wimplicit-fallthrough=2.
If you have patches to make the entire tree compile with
-Wimplicit-fallthrough=3, we can talk. You'd have to test them on all
supported hosts, and with a sufficient range of configurations to ensure
they are not breaking builds.
[Prev in Thread] | Current Thread | [Next in Thread] |