qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] configure: default to PIE disabled on Windows platforms


From: Thomas Huth
Subject: Re: [PATCH] configure: default to PIE disabled on Windows platforms
Date: Tue, 25 Aug 2020 07:37:38 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 24/08/2020 18.31, Daniel P. Berrangé wrote:
If Windows EXE files are built with -pie/-fpie they will fail to
launch. Historically QEMU defaulted to disabling PIE for Windows,
but this setting was accidentally lost when the configure summary
text was removed in

   commit f9332757898a764d85e19d339ec421236e885b68
   Author: Paolo Bonzini <pbonzini@redhat.com>
   Date:   Mon Feb 3 13:28:38 2020 +0100

     meson: move summary to meson.build

     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Fixes: f9332757898a764d85e19d339ec421236e885b68
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
  configure | 1 +
  1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 67832e3bab..b6f3b6e191 100755
--- a/configure
+++ b/configure
@@ -857,6 +857,7 @@ MINGW32*)
      audio_drv_list=""
    fi
    supported_os="yes"
+  pie="no"
  ;;
  GNU/kFreeBSD)
    bsd="yes"


Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]