[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/11] MAINTAINERS: Add an entry for common Renesas periph
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 05/11] MAINTAINERS: Add an entry for common Renesas peripherals |
Date: |
Thu, 11 Jun 2020 09:45:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/11/20 9:38 AM, Thomas Huth wrote:
> On 11/06/2020 00.08, Philippe Mathieu-Daudé wrote:
>> Renesas peripherals are common to SH4/RX based MCUs. Their
>> datasheets share common sections. It makes sense to maintain
>> them altogether. The current names are misleading (see the
>> 'sh' prefix). This will be fixed later when RX peripherals
>> will be added.
>>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> MAINTAINERS | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 653fca1da8..0398634179 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1254,8 +1254,6 @@ M: Magnus Damm <magnus.damm@gmail.com>
>> S: Odd Fixes
>> F: hw/sh4/r2d.c
>> F: hw/intc/sh_intc.c
>> -F: hw/timer/sh_timer.c
>> -F: include/hw/sh4/sh_intc.h
>
> You've added the line for sh_intc.h in the previous patch, just to
> remove it here again? ... I guess you only wanted to remove sh_timer.c
> here instead?
Yes, you are right, too many rework trying to split in a way that
would satisfy Aleksander requirements, but he eventually implicitly
Nacked this series (not replying on the cover however, and not
answering my questions, so this is not clear neither...):
https://www.mail-archive.com/qemu-devel@nongnu.org/msg711260.html
Aleksander said Yoshinori will arrange the sections in his own
ways. While I'm not certain Yoshinori is interested/willing to do
the cleanup, I don't think any more reviewer should spend time
reviewing this. Thanks for caring anyway, very appreciated!
>
> Thomas
>
>> Shix
>> S: Orphan
>> @@ -1954,6 +1952,13 @@ F: hw/*/*xive*
>> F: include/hw/*/*xive*
>> F: docs/*/*xive*
>>
>> +Renesas peripherals
>> +M: Magnus Damm <magnus.damm@gmail.com>
>> +S: Odd Fixes
>> +F: hw/char/sh_serial.c
>> +F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/sh.h
>> +
>> Subsystems
>> ----------
>> Audio
>>
>
- [PATCH v3 00/11] sh4: Update MAINTAINERS & trivial fixes, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 01/11] MAINTAINERS: Mark SH4 section orphan, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 02/11] MAINTAINERS: Mark SH4 based Shix machine orphan, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 03/11] MAINTAINERS: Demote SH4 based R2D machine to 'Odd Fixes', Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 05/11] MAINTAINERS: Add an entry for common Renesas peripherals, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 04/11] MAINTAINERS: Cover 'hw/sh4/sh_intc.h' with the R2D machine, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 06/11] MAINTAINERS: Add Yoshinori Sato as maintainer of Renesas peripherals, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 07/11] hw/sh4: Use MemoryRegion typedef, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 08/11] hw/sh4: Extract timer definitions to 'hw/timer/tmu012.h', Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 09/11] hw/timer/sh_timer: Remove unused 'qemu/timer.h' include, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 10/11] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH v3 11/11] .travis.yml: Test SH4 QEMU advent calendar image, Philippe Mathieu-Daudé, 2020/06/10