[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] hw/display/cirrus_vga: Convert debug printf() to qemu_lo
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 0/4] hw/display/cirrus_vga: Convert debug printf() to qemu_log_mask & trace |
Date: |
Sun, 24 May 2020 15:54:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/24/20 2:26 PM, address@hidden wrote:
>
> This series seems to have some coding style problems. See output below for
> more information:
>
[...]
> 3/4 Checking commit 0b01a633fe92 (hw/display/cirrus_vga: Use
> qemu_log_mask(ERROR) instead of debug printf)
> ERROR: suspect code indent for conditional statements (16, 12)
> #31: FILE: hw/display/cirrus_vga.c:1038:
> if (s->cirrus_blt_pixelwidth > 2) {
> + qemu_log_mask(LOG_GUEST_ERROR,
False positive. Checkpatch is confused by the mis-indented code previous
to this line.
>
> total: 1 errors, 0 warnings, 156 lines checked
>
> Patch 3/4 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
[...]
- [PATCH 0/4] hw/display/cirrus_vga: Convert debug printf() to qemu_log_mask & trace, Philippe Mathieu-Daudé, 2020/05/24
- [PATCH 1/4] hw/display/cirrus_vga: Convert debug printf() to trace event, Philippe Mathieu-Daudé, 2020/05/24
- [PATCH 2/4] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf, Philippe Mathieu-Daudé, 2020/05/24
- [PATCH 4/4] hw/display/cirrus_vga: Convert debug printf() to trace event, Philippe Mathieu-Daudé, 2020/05/24
- [PATCH 3/4] hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf, Philippe Mathieu-Daudé, 2020/05/24
- Re: [PATCH 0/4] hw/display/cirrus_vga: Convert debug printf() to qemu_log_mask & trace, no-reply, 2020/05/24
- Re: [PATCH 0/4] hw/display/cirrus_vga: Convert debug printf() to qemu_log_mask & trace,
Philippe Mathieu-Daudé <=