[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] io/task: Move 'qom/object.h' header to source
From: |
Richard Henderson |
Subject: |
Re: [PATCH 2/3] io/task: Move 'qom/object.h' header to source |
Date: |
Mon, 4 May 2020 10:42:58 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/4/20 1:46 AM, Philippe Mathieu-Daudé wrote:
> We need "qom/object.h" to call object_ref()/object_unref().
This description doesn't seem to match
> +++ b/include/io/task.h
> @@ -21,8 +21,6 @@
> #ifndef QIO_TASK_H
> #define QIO_TASK_H
>
> -#include "qom/object.h"
> -
> typedef struct QIOTask QIOTask;
>
> typedef void (*QIOTaskFunc)(QIOTask *task,
> diff --git a/io/task.c b/io/task.c
> index 1ae7b86488..53c0bed686 100644
> --- a/io/task.c
> +++ b/io/task.c
> @@ -22,6 +22,7 @@
> #include "io/task.h"
> #include "qapi/error.h"
> #include "qemu/thread.h"
> +#include "qom/object.h"
the change. Since io/task.c includes io/tash.h, what are you actually doing?
r~
- [PATCH 0/3] qom: Few trivial patches, Philippe Mathieu-Daudé, 2020/05/04
- [PATCH 1/3] qom/object: Move Object typedef to 'qemu/typedefs.h', Philippe Mathieu-Daudé, 2020/05/04
- [PATCH 3/3] qom/object: Make reparenting error more verbose, Philippe Mathieu-Daudé, 2020/05/04
- [PATCH 2/3] io/task: Move 'qom/object.h' header to source, Philippe Mathieu-Daudé, 2020/05/04
- Re: [PATCH 2/3] io/task: Move 'qom/object.h' header to source,
Richard Henderson <=
- Re: [PATCH 0/3] qom: Few trivial patches, no-reply, 2020/05/04
- Re: [PATCH 0/3] qom: Few trivial patches, no-reply, 2020/05/04