[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 01/19] scsi/esp-pci: add g_assert() for fix clang analyzer warn
From: |
Laurent Vivier |
Subject: |
[PULL v2 01/19] scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write() |
Date: |
Mon, 4 May 2020 17:59:38 +0200 |
From: Chen Qun <address@hidden>
Clang static code analyzer show warning:
hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read
size = 4;
^ ~
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/scsi/esp-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
index d5a1f9e01748..497a8d590190 100644
--- a/hw/scsi/esp-pci.c
+++ b/hw/scsi/esp-pci.c
@@ -197,6 +197,7 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
addr &= ~3;
size = 4;
}
+ g_assert(size >= 4);
if (addr < 0x40) {
/* SCSI core reg */
--
2.26.2
- [PULL v2 00/19] Trivial branch for 5.1 patches, Laurent Vivier, 2020/05/04
- [PULL v2 05/19] hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug(), Laurent Vivier, 2020/05/04
- [PULL v2 06/19] hw/mem/pc-dimm: Fix line over 80 characters warning, Laurent Vivier, 2020/05/04
- [PULL v2 04/19] MAINTAINERS: Mark the LatticeMico32 target as orphan, Laurent Vivier, 2020/05/04
- [PULL v2 02/19] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32(), Laurent Vivier, 2020/05/04
- [PULL v2 07/19] elf_ops: Don't try to g_mapped_file_unref(NULL), Laurent Vivier, 2020/05/04
- [PULL v2 08/19] MAINTAINERS: Update Keith Busch's email address, Laurent Vivier, 2020/05/04
- [PULL v2 03/19] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write(), Laurent Vivier, 2020/05/04
- [PULL v2 12/19] blockdev: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 01/19] scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write(),
Laurent Vivier <=
- [PULL v2 10/19] Compress lines for immediate return, Laurent Vivier, 2020/05/04
- [PULL v2 09/19] chardev: Add macOS to list of OSes that support -chardev serial, Laurent Vivier, 2020/05/04
- [PULL v2 13/19] hw/i2c/pm_smbus: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 17/19] hw/gpio/aspeed_gpio: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 19/19] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning, Laurent Vivier, 2020/05/04
- [PULL v2 15/19] hw/ide/sii3112: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 11/19] block: Avoid dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 14/19] hw/input/adb-kbd: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 16/19] hw/isa/i82378: Remove dead assignment, Laurent Vivier, 2020/05/04
- [PULL v2 18/19] hw/timer/stm32f2xx_timer: Remove dead assignment, Laurent Vivier, 2020/05/04