[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()
|
From: |
Chenqun (kuhn) |
|
Subject: |
RE: [PATCH v4] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write() |
|
Date: |
Sat, 14 Mar 2020 03:15:18 +0000 |
>-----Original Message-----
>From: Peter Maydell [mailto:address@hidden]
>Sent: Friday, March 13, 2020 10:29 PM
>To: Chenqun (kuhn) <address@hidden>
>Cc: QEMU Developers <address@hidden>; QEMU Trivial <qemu-
>address@hidden>; Zhanghailiang <address@hidden>;
>Euler Robot <address@hidden>; Jason Wang
><address@hidden>; Peter Chubb <address@hidden>
>Subject: Re: [PATCH v4] hw/net/imx_fec: write TGSR and TCSR3 in
>imx_enet_write()
>
>On Fri, 13 Mar 2020 at 12:33, Chen Qun <address@hidden> wrote:
>>
>> The current code causes clang static code analyzer generate warning:
>> hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read
>> value = value & 0x0000000f;
>> ^ ~~~~~~~~~~~~~~~~~~
>> hw/net/imx_fec.c:864:9: warning: Value stored to 'value' is never read
>> value = value & 0x000000fd;
>> ^ ~~~~~~~~~~~~~~~~~~
>>
>> According to the definition of the function, the two “value”
>> assignments should be written to registers.
>>
>> Reported-by: Euler Robot <address@hidden>
>> Signed-off-by: Chen Qun <address@hidden>
>
>
>Applied to target-arm.next; thanks for working through the code review
>process.
>
Thank you for your detailed review and effective suggestions, too.