[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/9] hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB
From: |
Stefano Garzarella |
Subject: |
Re: [PATCH v2 2/9] hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bss |
Date: |
Thu, 5 Mar 2020 14:48:37 +0100 |
On Thu, Mar 05, 2020 at 02:44:03PM +0100, Stefano Garzarella wrote:
> On Thu, Mar 05, 2020 at 01:45:18PM +0100, Philippe Mathieu-Daudé wrote:
> > This buffer is only used by the adlib audio device. Move it to
> > the .heap to release 32KiB of .bss (size reported on x86_64 host).
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> > hw/audio/fmopl.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
> > index 173a7521f2..356d4dfbca 100644
> > --- a/hw/audio/fmopl.c
> > +++ b/hw/audio/fmopl.c
> > @@ -186,7 +186,7 @@ static int32_t *VIB_TABLE;
> >
> > /* envelope output curve table */
> > /* attack + decay + OFF */
> > -static int32_t ENV_CURVE[2*EG_ENT+1];
> > +static int32_t *ENV_CURVE;
> >
> > /* multiple table */
> > #define ML 2
> > @@ -1090,6 +1090,7 @@ FM_OPL *OPLCreate(int clock, int rate)
> > OPL->clock = clock;
> > OPL->rate = rate;
> > OPL->max_ch = max_ch;
> > + ENV_CURVE = g_new(int32_t, 2 * EG_ENT + 1);
Should we use g_new0() ?
> > /* init grobal tables */
> > OPL_initialize(OPL);
> > /* reset chip */
> > @@ -1127,6 +1128,7 @@ void OPLDestroy(FM_OPL *OPL)
> > #endif
> > OPL_UnLockTable();
> > free(OPL);
> > + g_free(ENV_CURVE);
>
> Just for curiosity, here the entire fmopl.c is indented with tabs.
>
> In this case, is it better to continue with the tabs or use spaces
> for new changes?
>
> Anyway the changes LGTM:
> Reviewed-by: Stefano Garzarella <address@hidden>
[PATCH v2 3/9] hw/audio/intel-hda: Use memory region alias to reduce .rodata by 4.34MB, Philippe Mathieu-Daudé, 2020/03/05
[PATCH v2 4/9] hw/net/e1000: Add readops/writeops typedefs, Philippe Mathieu-Daudé, 2020/03/05
[PATCH v2 5/9] hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data, Philippe Mathieu-Daudé, 2020/03/05
[PATCH v2 6/9] hw/usb/quirks: Use smaller types to reduce .rodata by 10KiB, Philippe Mathieu-Daudé, 2020/03/05
[PATCH v2 8/9] ui/curses: Move arrays to .heap to save 74KiB of .bss, Philippe Mathieu-Daudé, 2020/03/05
[PATCH v2 7/9] ui/curses: Make control_characters[] array const, Philippe Mathieu-Daudé, 2020/03/05