[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_ro
From: |
Chenqun (kuhn) |
Subject: |
RE: [PATCH 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() |
Date: |
Tue, 25 Feb 2020 10:12:09 +0000 |
>-----Original Message-----
>From: Philippe Mathieu-Daudé [mailto:address@hidden]
>Sent: Tuesday, February 25, 2020 5:45 PM
>To: Chenqun (kuhn) <address@hidden>; qemu-
>address@hidden; address@hidden
>Cc: address@hidden; Zhanghailiang
><address@hidden>; Dr. David Alan Gilbert
><address@hidden>
>Subject: Re: [PATCH 13/13] monitor/hmp-cmds: Remove redundant
>statement in hmp_rocker_of_dpa_groups()
>
>On 2/25/20 3:09 AM, address@hidden wrote:
>> From: Chen Qun <address@hidden>
>>
>> Clang static code analyzer show warning:
>> monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
>> set = true;
>> ^ ~~~~
>>
>> Reported-by: Euler Robot <address@hidden>
>> Signed-off-by: Chen Qun <address@hidden>
>> ---
>> Cc: "Dr. David Alan Gilbert" <address@hidden>
>> ---
>> monitor/hmp-cmds.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index
>> 53bc3f76c4..84f94647cd 100644
>> --- a/monitor/hmp-cmds.c
>> +++ b/monitor/hmp-cmds.c
>> @@ -2864,7 +2864,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon,
>> const QDict *qdict)
>>
>> if (group->has_set_eth_dst) {
>> if (!set) {
>> - set = true;
>> monitor_printf(mon, " set");
>> }
>> monitor_printf(mon, " dst %s", group->set_eth_dst);
>>
>
>Can you move the 'set' declaration to the for() statement and also remove the
>last "set = false;"?
Yes, you are right! It will be better! I will modify it later in V2.
Thanks.
- [PATCH 00/13]redundant code: Fix warnings reported by Clang static code analyzer, kuhn.chenqun, 2020/02/24
- [PATCH 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v(), kuhn.chenqun, 2020/02/24
- [PATCH 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups(), kuhn.chenqun, 2020/02/24
- [PATCH 08/13] display/blizzard: Remove redundant statement in blizzard_draw_line16_32(), kuhn.chenqun, 2020/02/24
- [PATCH 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock(), kuhn.chenqun, 2020/02/24
- [PATCH 04/13] scsi/esp-pci: Remove redundant statement in esp_pci_io_write(), kuhn.chenqun, 2020/02/24
- [PATCH 05/13] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command(), kuhn.chenqun, 2020/02/24
- [PATCH 07/13] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update(), kuhn.chenqun, 2020/02/24
- [PATCH 12/13] usb/hcd-ehci: Remove redundant statements, kuhn.chenqun, 2020/02/24
- [PATCH 01/13] block/stream: Remove redundant statement in stream_run(), kuhn.chenqun, 2020/02/24
- [PATCH 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst(), kuhn.chenqun, 2020/02/24