Re: [PATCH 2/3] hw/ppc/virtex_ml507:fix leak of fdevice tree blob

[David Gibson]

On Tue, Feb 18, 2020 at 05:11:53PM +0800, address@hidden wrote:
> From: Chen Qun <address@hidden>
> 
> The device tree blob returned by load_device_tree is malloced.
> We should free it after cpu_physical_memory_write().
> 
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>

I've applied this patch to my ppc-for-5.0 staging tree.

> ---
>  hw/ppc/virtex_ml507.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
> index 91dd00ee91..4eef70069f 100644
> --- a/hw/ppc/virtex_ml507.c
> +++ b/hw/ppc/virtex_ml507.c
> @@ -188,6 +188,7 @@ static int xilinx_load_device_tree(hwaddr addr,
>      if (r < 0)
>          fprintf(stderr, "couldn't set /chosen/bootargs\n");
>      cpu_physical_memory_write(addr, fdt, fdt_size);
> +    g_free(fdt);
>      return fdt_size;
>  }
>  

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature