[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_ini
From: |
Peter Maydell |
Subject: |
Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init |
Date: |
Thu, 13 Feb 2020 16:37:41 +0000 |
On Thu, 13 Feb 2020 at 16:33, Philippe Mathieu-Daudé <address@hidden> wrote:
> > * unrealize() must clean up everything realize() creates.
>
> Hmm I guess remember someone once said "only for hot-pluggable objects,
> else don't bother". But then we make a non-hot-pluggable object as
> hot-pluggable and have to fix leaks. Or we start a new hot-pluggable
> device based on some code without unrealize()...
Yeah. Almost all our devices are not hot-pluggable and don't
have unrealize code. Better to just have them stay that way,
or to add untested unreachable code in an unrealize method? Dunno.
thanks
-- PMM
- [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init, kuhn.chenqun, 2020/02/11
- Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init, Philippe Mathieu-Daudé, 2020/02/12
- RE: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init, Chenqun (kuhn), 2020/02/12
- Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init, Philippe Mathieu-Daudé, 2020/02/12
- Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init, Eduardo Habkost, 2020/02/12
- RE: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init, Chenqun (kuhn), 2020/02/12
- Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init, Markus Armbruster, 2020/02/13
- Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init, Philippe Mathieu-Daudé, 2020/02/13
- Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init,
Peter Maydell <=